Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming Search: results should be rendered as they come in #15546

Closed
limitedmage opened this issue Nov 6, 2020 · 2 comments · Fixed by #16097
Closed

Streaming Search: results should be rendered as they come in #15546

limitedmage opened this issue Nov 6, 2020 · 2 comments · Fixed by #16097
Assignees
@limitedmage
Projects
Search team :: streaming search

Comments

@limitedmage
Copy link
Contributor

limitedmage commented Nov 6, 2020 •
edited

Right now, we are waiting for streaming search to be done before rendering results. Results (and other events such as progress updates and suggested filters) should be rendered as they come in.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2020

Heads up @lguychard - the "team/search" label was applied to this issue.

@limitedmage limitedmage self-assigned this Nov 20, 2020
@limitedmage limitedmage linked a pull request Dec 3, 2020 that will close this issue
search frontend: render streaming search results #16097
Merged
@limitedmage
Copy link
Contributor Author

Fixed with #16097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@limitedmage limitedmage

Labels
None yet
Projects
Search team :: streaming search
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

search frontend: render streaming search results sourcegraph/sourcegraph
1 participant
@limitedmage