GraphQL API returns invalid repository and tree URLs for repo with spaces in name (not percent-encoded)

[felixfbecker]

This is the root cause of #15615, which affects https://app.hubspot.com/contacts/2762526/company/1085513342.

Repro:

1. Go to https://k8s.sgdev.org/sourcegraph.visualstudio.com/Test%20Repo
2. Check the network tab for the RepositoryRedirect and ResolveRev queries.

Actual:
RepositoryRedirect has repositoryRedirect.url: "/sourcegraph.visualstudio.com/Test Repo"
ResolveRev has repositoryRedirect.commit.tree.url: "/sourcegraph.visualstudio.com/Test Repo"

which are invalid URLs and cause React client routing to break.

Expected:
Both should be "/sourcegraph.visualstudio.com/Test%20Repo"

[github-actions]

Heads up @tsenart - the "team/cloud" label was applied to this issue.

[felixfbecker]

@unknwon I found the resolvers at fault and pushed a PR here to save you time: #15745

However, I am not sure if I did everything correctly regarding code layout and testing. Do you want to take the PR over and push any changes or additional tests that should be done?

[unknwon]

@felixfbecker Thanks! I'll take it from there.