Cloud 2020-11-18 Tracking issue

[tsenart]

Period

From 2020-11-18 to 2020-12-01. Sourcegraph 3.22 and 3.23 release window.

Availability

If you have planned unavailability this iteration (e.g., vacation), you can note that here.

• @flying-robot 11/23 - 11/27 (Thanksgiving week)

Tracked issues

@artemruts: 2.00d

• Update email settings UI and handle account reunification (#15409; PRs: #15778) 2.00d

@arussellsaw: 4.00d

• Unable to add a repository which has a plus sign (+) in the URL (#15079)

Completed: 4.00d

• (🏁 13 days ago) authz: faster repository permissions syncing via GitHub webhook (#14917) 2.00d 🕵️
• (🏁 13 days ago) Migrate campaigns webhooks to new scaffolding / infrastructure (#15337) 2.00d
• (🏁 today) Repositories view in settings (#15401; PRs: #16236)

@asdine: 0.50d

Completed: 0.50d

• (🏁 7 days ago) Merge external service types (#16115)
• (🏁 6 days ago) Allow synchronization of private repos if owner has AllowUserExternalServicePrivate tag (#16023; PRs: #16123) 0.50d 🐛
• (🏁 5 days ago) Move tag checking logic to User store (#16166)

@flying-robot: 4.00d

Completed: 4.00d

• (🏁 13 days ago) authz: faster repository permissions syncing via GitHub webhook (#14917) 2.00d 🕵️
• (🏁 13 days ago) Migrate campaigns webhooks to new scaffolding / infrastructure (#15337) 2.00d
• (🏁 12 days ago) qa: remove tests covered by backend integration/unit tests (#15893) 🐛

@keegancsmith: 1.00d

Completed: 1.00d

• (🏁 1 day ago) Research: Simplify access to repository tokens for gitserver (#14910) 1.00d 🔒🕵️🧶

@ryanslade: 4.50d

• github-proxy: Instrument mutex contention (#16312)

Completed: 4.50d

• (🏁 13 days ago) frontend: Log sync error after external service deletion (#15911)
• (🏁 12 days ago) db: User owned code host connections should not allow rate limits (#15923)
• (🏁 12 days ago) Disallow rate limits on user owned connections (#15744) 0.50d
• (🏁 8 days ago) sourcegraph/customer (#139) 👩
• (🏁 7 days ago) repo-updater: Enforce unique constraint on external_service_repos (#16022)
• (🏁 5 days ago) User-added repos do not stay indexed on Sourcegraph.com (#15820; PRs: #16176) 1.00d 🐛
• (🏁 4 days ago) Deleting external services triggers too many queries (#16069; PRs: #16163) 1.00d 🐛
• (🏁 today) Clean up external_service_repos and external_services table on Sourcegraph.com (#15797) 2.00d 🐛
• (🏁 today) db: Drop duplicate index. (#16286)

@tsenart: 1.00d

Completed: 1.00d

• (🏁 12 days ago) [Cloud] [CRITICAL] gitserver: 2s+ echo command duration test fires regularly (#15392; PRs: #15971)
• (🏁 8 days ago) gitserver: Avoid double HTTP response header writing (#16072)
• (🏁 7 days ago) monitoring: Change syntect_server owner to Cloud team (#16083)
• (🏁 1 day ago) Research: Simplify access to repository tokens for gitserver (#14910) 1.00d 🔒🕵️🧶

@unknwon: 6.00d

Completed: 6.00d

• (🏁 12 days ago) Stop truncating microsecond everywhere with a util package (#11246; PRs: #15968) 0.50d 🧶
• (🏁 11 days ago) authz: remove authzFilter along with its metric and tests (#15731; PRs: #16006) 1.00d 🧶
• (🏁 11 days ago) Remove database secret encryption (#15868; PRs: #16008) 0.50d 🔒🧶
• (🏁 8 days ago) external_services: remove migration for unrestricted column in 3.23 (#15571; PRs: #16063) 🧶
• (🏁 7 days ago) Simplify PermsStore logic with intarray extension (#11768; PRs: #16003) 1.00d 🧶
• (🏁 7 days ago) authz: utilize expired_at and last_valid_at columns of user_external_accounts (#16067)
• (🏁 4 days ago) Move aggregated repository statistics to critical telemetry (#15883; PRs: #16188) 0.50d
• (🏁 4 days ago) Show lines of code in site-admin overview and on the manage repositories page (#15125; PRs: #16190) 1.00d
• (🏁 4 days ago) External services is not set as unrestricted when "authorization" presents in comment (#16068; PRs: #16211) 0.50d 🐛
• (🏁 1 day ago) gqltest: add test for external code host links (#16206; PRs: #16231) 0.50d
• (🏁 1 day ago) Audit all requests to gitserver and make sure responses are authz checked before responding to users (#16191) 0.50d 🔒

Legend

• 👩 Customer issue
• 🐛 Bug
• 🧶 Technical debt
• 🎩 Quality of life
• 🛠️ Roadmap
• 🕵️ Spike
• 🔒 Security issue
• Pull Request

[github-actions]

Heads up @tsenart - the "team/cloud" label was applied to this issue.

[flying-robot]

This cycle is going to be shorter for me, so I grabbed two login issues off the bat since they're related / straightforward.

[unknwon]

This cycle is going to be shorter for me, so I grabbed two login issues off the bat since they're related / straightforward.

@flying-robot Your workload (7.5d) doesn't look like so 😂

[arussellsaw]

This week was mostly getting to grips with the frontend codebase & graphql, but i've made good progress on the repositories settings page. Next week is where the larger uncertainty lies, as there are some elements of the design that will require pretty big changes to the implementation of FilteredConnection used by most list views in the app. I'll chat with @quinnkeast and @felixfbecker next week to see what we think the best approach is.

[unknwon]

Last week

• No more application-level authz for repository permissions, authzFilter has been removed.
• Simplified PermsStore logic with intarray extension.

This week

• Get last approval from @gonza for RFC 266: Production testing of all authorization models.
• Finish authz: clean up rows that have broken auth_data in user_external_accounts (authz: clean up rows that have broken auth_data in user_external_accounts #14899)
• Finish moving aggregated repository statistics to critical telemetry (Move aggregated repository statistics to critical telemetry #15883)
• Start work of showing lines of code in site-admin overview and on the manage repositories page (Show lines of code in site-admin overview and on the manage repositories page #15125)

[ryanslade]

Last week

• Investigated issues around data stored in our external_service_repos table. Cleaned up a lot of the erroneous data and opened a PR to fix the root cause: repo-updater: Enforce unique constraint on external_service_repos #16022
• Investigated a customer issue: https://github.com/sourcegraph/customer/issues/139. Found a workaround and will work on a proper fix next week.

This week

• Work on proper fix to customer issue above
• Focus on 🐛 issues
• Help with any work needed to unblock @artemruts' frontend changes

[asdine]

Last week

• Investigated an external service sync issue with Github Enterprise eror msg=store.upsert-repos error="DBStore.UpsertRepos did not set ID for Repo #14907. I didn't manage to find the root cause and asked the author to share more logs. I worked on a PR to make the repo-updater store more solid and to add more logs.

This week

• Start with bugs and customer issues
• Now that the release is out, finish the ongoing work on repo-updater's store tech debt
• Improve shared stores

[unknwon]

Last week

• Moved git disk size and indexed LoC to pings critical metrics and display in site admin overview.
• Paired with @asdine on breaking up the huge tech debt PR.

This week

• gqltest: add test for external code host links (gqltest: add test for external code host links #16206)
• Audit all requests to gitserver and make sure responses are authz checked before responding to users (Audit all requests to gitserver and make sure responses are authz checked before responding to users #16191)
• Cycle grooming and planning

[asdine]

Last week

• Paired with @unknwon on breaking up the big repo updater tech debt PR Replace calls to old repo-updater store and types by the new store #15530
• Worked on a few customer issues that either need more context or don't appear to be issues Display user analytics according to instance server date/time  #15876 Excluded GitLab repositories are synced  #15763
• Use tag to allow syncing private repositories Sync private repositories when service owner has TagAllowUserExternalServicePrivate tag #16123

This week

• Keep working on breaking up the tech debt PR and satellite issues
• National holidays most of the week