-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse sign-in OAuth workflow for code host connections #17356
Comments
Heads up @tsenart - the "team/cloud" label was applied to this issue. |
It appears that we already support this workflow. If we attempt to "sign in with codehost" after a user is already authenticated then we'll link the external account with the currently logged in user. I've tested this locally in the following way:
|
@artemruts Did you confirm that the above works, can we close this? |
@ryanslade I'll close this after code goes through QA, I believe it works :) |
@artemruts: Can we get a demo video to share in #progress? |
Description
To reuse existing "sign-in with" OAuth workflow for code host connections, we need to have a secure way to tell the sign-in-workflow to bind given code host (user external account) to user and not with an email but with a special ID X, where X could be an opaque user ID.
Otherwise we need to require users to add their email address (of what they have in the code host) before creating code host OAuth connection. If user won't have an email address, we may end up creating a new Sourcegraph account. 🙅
Links
The text was updated successfully, but these errors were encountered: