Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback and command line button in nav flash on page load #26435

Closed
eseliger opened this issue Oct 21, 2021 · 1 comment · Fixed by #27075
Closed

Feedback and command line button in nav flash on page load #26435

eseliger opened this issue Oct 21, 2021 · 1 comment · Fixed by #27075
Assignees
@gitstart-sourcegraph
Labels
frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. gitstart Contract partner
Projects
GitStart Work

Comments

@eseliger
Copy link
Member

eseliger commented Oct 21, 2021 •
edited by valerybugakov

Problem statement

Command buttons are flashing. Seems like it's a transition problem.

Screen.Recording.2021-10-21.at.5.13.00.PM.mov

Success criteria

Command buttons are not flashing on page load.
@eseliger eseliger changed the title Feedback and command line button in nav flash on page loade Feedback and command line button in nav flash on page load Oct 21, 2021
@eseliger eseliger added the frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. label Oct 21, 2021
@valerybugakov valerybugakov added the gitstart Contract partner label Oct 21, 2021
@valerybugakov valerybugakov added this to To do in GitStart Work Oct 21, 2021
@gitstart-sourcegraph gitstart-sourcegraph moved this from To do to In progress in GitStart Work Oct 28, 2021
@gitstart-sourcegraph gitstart-sourcegraph mentioned this issue Nov 4, 2021
Merged
@gitstart-sourcegraph gitstart-sourcegraph linked a pull request Nov 4, 2021 that will close this issue
Feedback and command line button in nav flash on page load #27075
Merged
@gitstart-sourcegraph gitstart-sourcegraph moved this from In progress to In review in GitStart Work Nov 4, 2021
@gitstart-sourcegraph gitstart-sourcegraph moved this from In review to In progress in GitStart Work Nov 8, 2021
@gitstart-sourcegraph
Copy link
Collaborator

gitstart-sourcegraph commented Nov 8, 2021 •
edited

@valerybugakov After investigated, I found a reason for this issue, it's the theme hook adds theme-light class into html element later than the time which those components are rendered at, so --border-color doesn't exist at the time they show up, they have the border color from other classes, and after that a little of time --border-color exists (in .theme-light scope), so border color changes another time.

I tried to use var(--gray-03) directly (instead of var(--border-color)) in client/web/src/nav/Feedback/FeedbackPrompt.module.scss > .toggle and the flashing effect is gone.

What do you think about this case?

https://sourcegraph.com/gitlab.com/sourcegraph/sourcegraph/-/blob/client/web/src/theme.ts?L72

@gitstart-sourcegraph gitstart-sourcegraph moved this from In progress to In spec review in GitStart Work Nov 9, 2021
@valerybugakov valerybugakov mentioned this issue Nov 10, 2021
Closed
@gitstart-sourcegraph gitstart-sourcegraph moved this from In spec review to In review in GitStart Work Nov 11, 2021
GitStart Work automation moved this from In review to Done Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitstart-sourcegraph gitstart-sourcegraph

Labels
frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. gitstart Contract partner
Projects
GitStart Work
Done
Milestone
No milestone
3 participants
@valerybugakov @eseliger @gitstart-sourcegraph