Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme picker doesn't show warning when "System" option selected in Chrome 73 #2749

Closed
ryan-blunden opened this issue Mar 14, 2019 · 2 comments
Closed

Theme picker doesn't show warning when "System" option selected in Chrome 73 #2749

ryan-blunden opened this issue Mar 14, 2019 · 2 comments
Assignees
@felixfbecker
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
Milestone
Backlog

Comments

@ryan-blunden
Copy link
Contributor

On macOS Mojave, I have the dark theme set, but when I choose System from the theme selector, it changes to light mode?

ScreenFlow
@ryan-blunden ryan-blunden added the bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. label Mar 14, 2019
@ryan-blunden ryan-blunden added this to the 3.2 milestone Mar 14, 2019
@ryan-blunden ryan-blunden changed the title Theme picker chooses light theme when "System" option selected Theme picker incorrectly chooses light theme when "System" option selected Mar 14, 2019
@felixfbecker
Copy link
Contributor

Chrome still doesn't support system theme. But the latest update made the feature detection return a false positive.

@felixfbecker felixfbecker modified the milestones: 3.2, Backlog Mar 15, 2019
@felixfbecker felixfbecker changed the title Theme picker incorrectly chooses light theme when "System" option selected Theme picker doesn't show warning when "System" option selected in Chrome 73 Mar 15, 2019
@felixfbecker
Copy link
Contributor

System theme is now supported in stable Chrome, Firefox, Safari and Edgium.

@realize096 realize096 mentioned this issue Sep 11, 2023
Open
@dixiemom1328 dixiemom1328 mentioned this issue Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixfbecker felixfbecker

Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@ryan-blunden @felixfbecker