Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility]: Compare page: Diff has poor color contrast #35536

Closed
3 of 4 tasks
umpox opened this issue May 17, 2022 · 1 comment
Closed
3 of 4 tasks

[Accessibility]: Compare page: Diff has poor color contrast #35536

umpox opened this issue May 17, 2022 · 1 comment
Assignees
Labels
accessibility a11y / accessibility estimate/0.5d frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. wcag/2.1/fixing wcag/2.1

Comments

@umpox
Copy link
Contributor

umpox commented May 17, 2022

Audit type

ARC Toolkit

User journey audit issue

#34426

Problem description

image

Expected behavior

We should work with design to improve the diff colors to ensure better color contrast.

Note: Both for dark and light mode.

Additional details

No response

Assigning labels

  • Please give this issue an estimate by applying a label like estimate/Xd, where X is the estimated number of days it will take to complete.
  • If this issue is specific to a specific Sourcegraph product, please assign the appropriate team label to this issue.
  • If this issue will require input from designers in order to complete, please assign the label needs-design.
  • If you are confident that this issue should be fixed by GitStart, please assign the label gitstart.

Owner

This issue will be fixed by my team, I have assigned a relevant member to it, or I will do so in the near future.

@umpox
Copy link
Contributor Author

umpox commented Jun 22, 2022

The work to fix this has been merged in #37385. It is currently feature flagged so we can test internally before enabling it site-wide.

We have an issue (#37535) to enable it fully over the coming weeks, closing this in favour of that!

@umpox umpox closed this as completed Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y / accessibility estimate/0.5d frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. wcag/2.1/fixing wcag/2.1
Projects
Status: Done
Status: Done
Development

No branches or pull requests

1 participant