unused site setting git.cloneURLToRepositoryName

[keegancsmith]

The documentation for this setting is

JSON array of configuration that maps from Git clone URL to repository name. Sourcegraph automatically resolves remote clone URLs to their proper code host. However, there may be non-remote clone URLs (e.g., in submodule declarations) that Sourcegraph cannot automatically map to a code host. In this case, use this field to specify the mapping. The mappings are tried in the order they are specified and take precedence over automatic mappings.

However, I do not see anywhere in our codebase we actually read this setting. We should remove this field. cc @sourcegraph/core-services to discuss.

[unknwon]

If I'm looking at the correct configuration git.cloneURLToRepositoryName, looks like it's still being used, call stack (bottom up):

conf.Get().GitCloneURLToRepositoryName:

sourcegraph/internal/conf/reposource/custom.go

Lines 31 to 33 in 87e0033

	var cloneURLResolvers = conf.Cached(func() interface{} {
	cloneURLConfig := conf.Get().GitCloneURLToRepositoryName
	var resolvers []*cloneURLResolver

cloneURLResolvers:

sourcegraph/internal/conf/reposource/custom.go

Lines 51 to 53 in 87e0033

	func CustomCloneURLToRepoName(cloneURL string) (repoName api.RepoName) {
	for _, r := range cloneURLResolvers().([]*cloneURLResolver) {
	if name := mapString(r.from, cloneURL, r.to); name != "" {

reposource.CustomCloneURLToRepoName:

sourcegraph/cmd/frontend/graphqlbackend/git_tree_entry.go

Lines 136 to 138 in 87e0033

	func reposourceCloneURLToRepoName(ctx context.Context, cloneURL string) (repoName api.RepoName, err error) {
	if repoName := reposource.CustomCloneURLToRepoName(cloneURL); repoName != "" {
	return repoName, nil

Calls of reposourceCloneURLToRepoName in GraphQL layer: https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24%4087e0033+file:%5Ecmd/frontend/graphqlbackend/+reposourceCloneURLToRepoName&patternType=literal

[unknwon]

I think this was a false positive, closing.