Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility]: Multiple H1 tags on Repository Page #39291

Closed
gitstart-sourcegraph opened this issue Jul 22, 2022 · 2 comments · Fixed by #39404
Closed

[Accessibility]: Multiple H1 tags on Repository Page #39291

gitstart-sourcegraph opened this issue Jul 22, 2022 · 2 comments · Fixed by #39404
Assignees
Labels
accessibility a11y / accessibility gitstart Contract partner wcag/2.1

Comments

@gitstart-sourcegraph
Copy link
Collaborator

gitstart-sourcegraph commented Jul 22, 2022

Problem statement

There are multiple <H1/> elements: the Sourcegraph logo in the navigation bar, and the page title, which produces a warning in ARC Toolkit in the following pages::

  1. Repository detail page
  2. Repository Commits Page
  3. Repository Compare Page

Expected Behaviour

The page title should be an <H2/>, but retain the current style.
All other <H2/>s on the page should be downscaled to <H3/>, but retain their current styles.
No warnings are reported under ARC Toolkit's "Structure and Semantics" tests.

Time estimate

  • Pull requests with ~450 lines changed should take X hours at maximum. Ping the reviewer in the spec pull request if time-consuming changes are required.
  • Split the work into multiple pull requests if the total diff is bigger than 450 lines of code.
@gitstart-sourcegraph gitstart-sourcegraph added the gitstart Contract partner label Jul 22, 2022
@gitstart-sourcegraph gitstart-sourcegraph self-assigned this Jul 22, 2022
@gitstart-sourcegraph gitstart-sourcegraph added accessibility a11y / accessibility team/search-product Issues owned by the search product team wcag/2.1 labels Jul 22, 2022
@sourcegraph-bot-2
Copy link
Collaborator

Heads up @benvenker @lguychard - the "team/search-product" label was applied to this issue.

@gitstart-app
Copy link
Contributor

gitstart-app bot commented Jul 22, 2022

Here is the GitStart Ticket for this issue: https://app.gitstart.com/clients/sourcegraph/tickets/SG-39291

@gitstart-sourcegraph gitstart-sourcegraph moved this from To do to In progress in GitStart Work Jul 25, 2022
@gitstart-sourcegraph gitstart-sourcegraph removed the team/search-product Issues owned by the search product team label Jul 27, 2022
@gitstart-sourcegraph gitstart-sourcegraph moved this from In progress to In review in GitStart Work Jul 27, 2022
GitStart Work automation moved this from In review to Done Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y / accessibility gitstart Contract partner wcag/2.1
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants