Enable no-console ESLint rule

[valerybugakov]

Problem statement

Enable no-console ESLint rule

Success criteria

1. no-console is set to error in the monorepo eslintrc.
2. no-console is disabled for server-side code (e.g., client/web/dev or gulpfile.js) and Storybook stories via eslintrc overrides field.
3. no-console is disabled for browser and VSCode packages in their eslintrc configs.
4. the new logError utility function is added to the @sourcegraph/common package.

   export function logError(...args: unknown[]): void {
       // eslint-disable-next-line no-console
       console.error(...args)
   }

5. console.error() calls are replaced with the new logError utility function.
6. console.log() calls are removed or replaced with the new logError utility function.

Time estimate

• This task should take 3 hours at maximum. Ping the reviewer in the spec pull request if time-consuming changes are required.

[sourcegraph-bot-2]

Heads up @taylorsperry @jasongornall - the "team/frontend-platform" label was applied to this issue.

[gitstart-app]

Here is the GitStart Ticket for this issue: https://app.gitstart.com/clients/sourcegraph/tickets/SG-39797

[gitstart-sourcegraph]

Hi @valerybugakov
For use cases such as client/shared/dev/suppressPollyErrors.js where we have usage such as console.group / console.groupEnd, and use cases of console.log as shown in the image below, where log message is meant to be informative instead of an error, WDYT about updating the utility function as recommended above, to include non error logs?.

[valerybugakov]

From the issue description:

no-console is disabled for server-side code (e.g., client/web/dev or gulpfile.js) and Storybook stories via eslintrc overrides field.

Hey @gitstart-sourcegraph, for non-application code, we should allow console usage. suppressPollyErrors.js is used to set up integration tests, so keeping these unchanged is fine. Disabling the rule for client/shared/dev is the best way to go here.