Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildkite generator generates no steps if only GitHub action YAML file is edited in PR, failing CI #39898

Closed
felixfbecker opened this issue Aug 3, 2022 · 2 comments · Fixed by #40028
Closed

Buildkite generator generates no steps if only GitHub action YAML file is edited in PR, failing CI #39898

felixfbecker opened this issue Aug 3, 2022 · 2 comments · Fixed by #40028
Labels
ci

Comments

@felixfbecker
Copy link
Contributor

See this build: https://buildkite.com/sourcegraph/sourcegraph/builds/165143#01826492-e910-4029-9fbc-81e930402936

And the PR: #39885

Only a YAML file for a GitHub action was edited. Expected would be that this results in an empty CI run (or a minimal one).

Instead, the build always fails because the pipeline generator generates no steps property at all, which is required.
@felixfbecker
Copy link
Contributor Author

I think I fixed this in 7c83be6

@felixfbecker
Copy link
Contributor Author

This is still an issue: https://sourcegraph.slack.com/archives/C01N83PS4TU/p1659643679886449
Example: #39972

@felixfbecker felixfbecker reopened this Aug 4, 2022
@jhchabran jhchabran mentioned this issue Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run linters on yaml and json files sourcegraph/sourcegraph
1 participant
@felixfbecker