Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insights: extend insights aggregation search decoder to support capture group matches #40211

Closed
chwarwick opened this issue Aug 10, 2022 · 1 comment · Fixed by #40714
Closed

insights: extend insights aggregation search decoder to support capture group matches #40211

chwarwick opened this issue Aug 10, 2022 · 1 comment · Fixed by #40714
Assignees
@CristinaBirkel
Labels
backend Any issue that needs work in the backend to close code-insights Issues related to the Code Insights product insights-search-aggregation-4.0 Aggregation in the search UI feature for Sourcegraph 4.0
Milestone
Insights iteratio...

Comments

@chwarwick
Copy link
Contributor

chwarwick commented Aug 10, 2022 •
edited by sourcegraph-bot-2

Extend the search decoder created in #40207 to provide the ability to aggregate on capture group matches similar to how the MatchOnly compute command works.

depends on #40207

/cc @Joelkw @felixfbecker @vovakulikov @unclejustin
@chwarwick chwarwick added code-insights Issues related to the Code Insights product backend Any issue that needs work in the backend to close insights-search-aggregation-4.0 Aggregation in the search UI feature for Sourcegraph 4.0 labels Aug 10, 2022
@chwarwick chwarwick added this to the Insights iteration 24 milestone Aug 10, 2022
Closed
80 tasks
@chwarwick chwarwick mentioned this issue Aug 16, 2022
Closed
@chwarwick
Copy link
Contributor Author

The match only command provides a pattern that we should be able to follow and can be found here

@CristinaBirkel CristinaBirkel self-assigned this Aug 17, 2022
@CristinaBirkel CristinaBirkel mentioned this issue Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CristinaBirkel CristinaBirkel

Labels
backend Any issue that needs work in the backend to close code-insights Issues related to the Code Insights product insights-search-aggregation-4.0 Aggregation in the search UI feature for Sourcegraph 4.0
Projects
None yet
Milestone
Insights iteration 25
Development

Successfully merging a pull request may close this issue.

insights: Add capture group aggregation sourcegraph/sourcegraph
2 participants
@chwarwick @CristinaBirkel