Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract bootstrap style import @import 'bootstrap/scss/reboot.scss' #40293

Closed
gitstart-sourcegraph opened this issue Aug 12, 2022 · 1 comment · Fixed by #40574
Closed

Extract bootstrap style import @import 'bootstrap/scss/reboot.scss' #40293

gitstart-sourcegraph opened this issue Aug 12, 2022 · 1 comment · Fixed by #40574
Assignees
Labels
frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. gitstart Contract partner

Comments

@gitstart-sourcegraph
Copy link
Collaborator

gitstart-sourcegraph commented Aug 12, 2022

Problem statement

We depend on Bootstrap styles in our global styles a lot. But we don't plan to move forward with Bootstrap because we're working on our design system called Wildcard. To ease the transition to our styles and gain more control over visual changes, we want to move Bootstrap styles that we need into our codebase and eventually drop Bootstrap dependency.

Ref

#29200

Success criteria

  1. All highlighted imports has been removed
  2. All css rules currently used from the imports are now available in style sheets

Implementation details

  1. Remove bootstrap import @import 'bootstrap/scss/reboot.scss
  2. copy style rules used in codebase from bootstrap stylesheet

Time estimate

  • Pull requests with ~450 lines changed should take 3 hours at maximum. Ping the reviewer in the spec pull request if time-consuming changes are required.
  • Split the work into multiple pull requests if the total diff is bigger than 450 lines of code.
@gitstart-sourcegraph gitstart-sourcegraph added the gitstart Contract partner label Aug 12, 2022
@gitstart-sourcegraph gitstart-sourcegraph self-assigned this Aug 12, 2022
@gitstart-sourcegraph gitstart-sourcegraph added the frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. label Aug 12, 2022
@gitstart-app
Copy link
Contributor

gitstart-app bot commented Aug 12, 2022

Here is the GitStart Ticket for this issue: https://app.gitstart.com/clients/sourcegraph/tickets/SG-40293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. gitstart Contract partner
Projects
Status: Done
1 participant