Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Insights: Conduct design UI/UX review for the aggregation project #40306

Closed
vovakulikov opened this issue Aug 12, 2022 · 3 comments · Fixed by #41212
Closed

Code Insights: Conduct design UI/UX review for the aggregation project #40306

vovakulikov opened this issue Aug 12, 2022 · 3 comments · Fixed by #41212
Assignees
@vovakulikov @AlicjaSuska
Labels
code-insights Issues related to the Code Insights product insights-search-aggregation-4.0 Aggregation in the search UI feature for Sourcegraph 4.0 webapp
Milestone
Insights iteratio...

Comments

@vovakulikov
Copy link
Contributor

vovakulikov commented Aug 12, 2022 •
edited by sourcegraph-bot-2

RFC
Figma Desings

Before shipping (turning on by default aggregation UI), we must conduct a proper design (UI/UX) review for new functionality.

/cc @Joelkw @felixfbecker @vovakulikov @unclejustin
@vovakulikov vovakulikov added webapp code-insights Issues related to the Code Insights product insights-search-aggregation-4.0 Aggregation in the search UI feature for Sourcegraph 4.0 labels Aug 12, 2022
@vovakulikov vovakulikov added this to the Insights iteration 25 milestone Aug 12, 2022
Closed
80 tasks
@vovakulikov vovakulikov mentioned this issue Aug 16, 2022
Merged
3 tasks
@vovakulikov
Copy link
Contributor Author

From sync - our goal to start this issue is the second week of iteration 25

@Joelkw
Copy link
Contributor

Joelkw commented Aug 18, 2022

sync notes from @AlicjaSuska – split this into 2, one for side panel, one for expanded view (stretch)

@AlicjaSuska
Copy link
Contributor

AlicjaSuska commented Aug 30, 2022 •
edited

Design QA page available here - it's a living page, I'll be adding items if I notice more problems. I'm sharing it early so we can start addressing the issues already listed there. @vovakulikov

Edit: First round of design QA is ready. For now, I'm keeping this issue open for re-review which will take place after fixes are implemented.

@vovakulikov vovakulikov self-assigned this Sep 1, 2022
@vovakulikov vovakulikov mentioned this issue Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vovakulikov vovakulikov

@AlicjaSuska AlicjaSuska

Labels
code-insights Issues related to the Code Insights product insights-search-aggregation-4.0 Aggregation in the search UI feature for Sourcegraph 4.0 webapp
Projects
None yet
Milestone
Insights iteration 25
Development

Successfully merging a pull request may close this issue.

Aggregation: Polish up aggregation UI sourcegraph/sourcegraph
4 participants
@unclejustin @Joelkw @vovakulikov @AlicjaSuska