Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/flake: nightly VSCE integration tests disabled #40891

Closed
taras-yemets opened this issue Aug 26, 2022 · 2 comments
Closed

ci/flake: nightly VSCE integration tests disabled #40891

taras-yemets opened this issue Aug 26, 2022 · 2 comments
Labels
ci/flake Does it sometimes fail, but if you retry it enough times, it passes, eventually? It's a flake. dx Issues and PRs related to developer experience concerns integrations testing Issues that deal with unit tests, integration tests and the testing infrastructure. vscode-extension

Comments

@taras-yemets
Copy link
Contributor

taras-yemets commented Aug 26, 2022 •
edited by sourcegraph-bot-2

Test

Nightly VSCE integration tests

Example failure

https://buildkite.com/sourcegraph/sourcegraph/builds/169322

Disabling PR

#40890

Additional details

No response

/cc @muratsu @jjinnii @ryankscott
@taras-yemets taras-yemets added testing Issues that deal with unit tests, integration tests and the testing infrastructure. dx Issues and PRs related to developer experience concerns ci/flake Does it sometimes fail, but if you retry it enough times, it passes, eventually? It's a flake. integrations vscode-extension labels Aug 26, 2022
@taras-yemets taras-yemets mentioned this issue Aug 26, 2022
Merged
Closed
45 tasks
@taras-yemets taras-yemets mentioned this issue Aug 30, 2022
Closed
@philipp-spiess
Copy link
Contributor

@taras-yemets We're unsure about the status of the fix. Does this need additional work?

@vdavid
Copy link
Contributor

vdavid commented Oct 4, 2022

@taras-yemets just responded that it doesn't need more work, closing this.

@vdavid vdavid closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci/flake Does it sometimes fail, but if you retry it enough times, it passes, eventually? It's a flake. dx Issues and PRs related to developer experience concerns integrations testing Issues that deal with unit tests, integration tests and the testing infrastructure. vscode-extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vsce: fix router issue sourcegraph/sourcegraph
3 participants
@philipp-spiess @vdavid @taras-yemets