Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insights: inaccurate tooltip for exhaustive aggregation results #41053

Closed
chwarwick opened this issue Aug 30, 2022 · 0 comments · Fixed by #41212
Closed

insights: inaccurate tooltip for exhaustive aggregation results #41053

chwarwick opened this issue Aug 30, 2022 · 0 comments · Fixed by #41212
Assignees
@vovakulikov
Labels
code-insights Issues related to the Code Insights product insights-search-aggregation-4.0 Aggregation in the search UI feature for Sourcegraph 4.0 webapp
Milestone
Insights iteratio...

Comments

@chwarwick
Copy link
Contributor

chwarwick commented Aug 30, 2022 •
edited by sourcegraph-bot-2

When an aggregation returns exhaustive results, not all groups may fit in the chart and are indicated with at +. Currently the tooltip states that the search was not exhaustive. This is not correct the user should be told that are are additional groups that do not fit in the chart.
Screen Shot 2022-08-30 at 12 09 37 PM

/cc @Joelkw @felixfbecker @vovakulikov @unclejustin
@chwarwick chwarwick added webapp code-insights Issues related to the Code Insights product insights-search-aggregation-4.0 Aggregation in the search UI feature for Sourcegraph 4.0 labels Aug 30, 2022
@chwarwick chwarwick added this to the Insights iteration 25 milestone Aug 30, 2022
Closed
80 tasks
@vovakulikov vovakulikov self-assigned this Sep 1, 2022
@vovakulikov vovakulikov mentioned this issue Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vovakulikov vovakulikov

Labels
code-insights Issues related to the Code Insights product insights-search-aggregation-4.0 Aggregation in the search UI feature for Sourcegraph 4.0 webapp
Projects
None yet
Milestone
Insights iteration 25
Development

Successfully merging a pull request may close this issue.

Aggregation: Polish up aggregation UI sourcegraph/sourcegraph
2 participants
@chwarwick @vovakulikov