Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.43.2: Patch release to fix context canceled errors in bitbucketserver code host sync #41400

Closed
11 tasks done
Tracked by #41485
indradhanush opened this issue Sep 7, 2022 · 3 comments
Closed
11 tasks done
Tracked by #41485
Labels
patch-release-request Patch release request: https://about.sourcegraph.com/handbook/engineering/releases

Comments

@indradhanush
Copy link
Contributor

indradhanush commented Sep 7, 2022

@sourcegraph/release-guild I am requesting the following commits be included in a patch release. They are already merged into main:


I have read when and why we perform patch releases and answer the questions as follows:

Are users/customers actively asking us for these changes and cannot wait until the next full release?

Yes. This is for the following customer.

Are the changes extremely minimal, well-tested, and low risk such that not testing as we do in a full release is OK?

Yes. The changes have been reviewed and tested. This adds a new endpoint for validating external services and changes the code to use this endpoint instead of the existing one when a sync is triggered manually from the site admin.

Is there some functionality completely broken that warrants redacting the prior release of Sourcegraph and advising users wait for the patch release?

Yes. Manually triggering a sync dumps a long chain of errors in the site admin.

This will interrupt our regular planned work and release cycle, taking one full working day of our time, and will take up all of our site admin's valuable time by asking them to upgrade or producing noise for them if they don't need to upgrade.

Do you believe the changes are important enough to warrant this?

Yes. See this channel on Slack.

Patch releases are a signal we can do something better to improve the quality of Sourcegraph. Have you already scheduled a call (or created a google doc) to perform a retrospective and identify ways we can improve?

No retro. This was a long standing issue which was hard to reproduce extending the timeline for the fix.


For the Release Captain - after reviewing this request:

  • Comment on this issue with a decision regarding the request.
  • If you are a first-time Release Captain, please review the high-level overview of the patch release process.
  • If approved, add it to a patch release:
    • If there is already an upcoming patch release, add the listed commits alongside a link to this issue
    • If there is no upcoming patch release, create a new one:
      • Update dev/release/release-config.jsonc and open a PR to main to update it
        • Change upcomingRelease to the current patch release
        • Change previousRelease to the previous patch release version
        • Change releaseDate to the current date (time is optional) along with oneWorkingDayAfterRelease and threeWorkingDaysBeforeRelease
        • Change captainSlackUsername and captainGitHubUsername to the patch captain's
      • Run yarn release tracking:issues on main
      • Add the listed commits alongside a link to this issue to the generated release tracking issue
  • Comment and close this issue once the relevant commit(s) have been cherry-picked into the release branch.
@indradhanush indradhanush changed the title 3.43.2: Fix context canceled errors in bitbucketserver code host sync 3.43.2: Patch release to fix context canceled errors in bitbucketserver code host sync Sep 7, 2022
@indradhanush indradhanush added the patch-release-request Patch release request: https://about.sourcegraph.com/handbook/engineering/releases label Sep 7, 2022
@indradhanush
Copy link
Contributor Author

I'm signing up as the patch captain to drive this ship to shore. 🚢

@unknwon
Copy link
Member

unknwon commented Sep 8, 2022

LGTM on behalf of the release guild 👍

@varsanojidan
Copy link
Contributor

Patch Released: #41485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-release-request Patch release request: https://about.sourcegraph.com/handbook/engineering/releases
Projects
None yet
Development

No branches or pull requests

3 participants