Add "open in editor" action

[fkling]

Tasks

Beta Give feedback

1. Implement new button
2. Add automated tests
3. Implement popover to configure editor

[bahrmichael]

Recap of what the OpenInEditorActionItem.tsx is currently doing (i.e. the things we need to do in the svelte version):

• Retrieving settings from the backend, and error handling (request fails or settings are invalid)
• Popover to change the editor integration (and its related race conditions)
• Handling multiple editors (e.g. Show a button with the editor icon for each registered editor )
• Constructing the URL that opens the file in the IDE
• Not showing the dropdown on small viewports, since we assume they won't have an IDE on their phones anyway
• Handling of special repo names (e.g. ones that include slashes). This part has a bit of history:
  • Bug: Open-in-editor extensions don't work with repo name with slashes #41713
  • Open in Editor: Fix paths for Perforce repos #41844
  • Open in Editor: Make paths backward compatible for self-hosted code hosts #41914
  • Open in Editor url doesn't consider repo name when repositorypathpattern is set for IntelliJ #43839
  • Open in Editor: Add filter for short URL patterns + test #44475

Open questions:

• Can we drop the code to migrate legacy settings? It's from September '22.

[bahrmichael]

To reduce the scope for the first iteration, I would cut the following features:

• Configuring an editor from the button. If the user has not configured a button, show a popover that tells them how they need to configure it in their user settings, and give them a link to there. Configuring an editor seems to have a lot of code that is just a nicer way than editing json in the user settings. This is a shortcut that we can remove later.
• Small viewport handling. Just show the button anyway. We can then test if our assumptions about small viewports are still valid with the rewrite. Reworked this so that a small icon is shown on small viewports, in alignment with how the other buttons behave.
• Telemetry recording. We don't seem to have that in the svelte app yet.
• Markdown rendering in tooltips. Reworked the messaging so it doesn't need markdown support.

[camdencheek]

@bahrmichael can this be closed after #61782?

[bahrmichael]

If we're okay with not bringing back the popover to configure an editor, then yes. I was planning to work on that this week, but if it's low prio I can drop it.

[fkling]

@bahrmichael I don't know if we need the popover but we can also track this in a separate issue if we don't finish it soon-ish.

[bahrmichael]

Will move the remaining work to a new task 👍