Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte: Remove "See more details" label #62306

Open
taiyab opened this issue Apr 30, 2024 · 1 comment
Open

Svelte: Remove "See more details" label #62306

taiyab opened this issue Apr 30, 2024 · 1 comment
Assignees

Comments

@taiyab
Copy link
Contributor

taiyab commented Apr 30, 2024

Context

This is our current results summary widget.

CleanShot 2024-04-30 at 19 53 15@2x

We should eliminate the label that says "See more details" to save vertical space. You should only get a notice there once of the conditions are met for an incomplete search, or whatever other states we have for that.

We could also:

  • Reduce the left icon size (to 16x16)
  • Reduce the size of the caret icon to the right (12x12)

Code Search (Figma)

@camdencheek
Copy link
Member

@taiyab If I understand how we got here correctly, we added the "see more details" because if there was nothing in that space, the page jumps when a search goes from showing a message to showing nothing. I don't think we want the search results to shift when a search completes. Thoughts on how to get around that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants