Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Users cannot make access requests when there is only one auth provider configured #62313

Closed
gabtorre opened this issue Apr 30, 2024 · 1 comment · Fixed by #62376
Closed

Bug: Users cannot make access requests when there is only one auth provider configured #62313

gabtorre opened this issue Apr 30, 2024 · 1 comment · Fixed by #62376
Assignees
@pjlast
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. customer Important issues reported or desired by a customer. team/source Tickets under the purview of Source - the one Source to graph it all

Comments

@gabtorre
Copy link
Contributor

  • Sourcegraph version: 5.3.11625
  • Platform information:

Steps to reproduce:

Configure Sourcegraph with only a single OAuth provider (e.g. GitHub)
Navigate to /sign-in as an anonymous user
Observe being immediately redirected to the OAuth provider instead of seeing the Sourcegraph sign-in page

Expected behavior:

Users should be able to access the Sourcegraph sign-in page even if there is only a single OAuth provider configured. This allows users to make access requests if signup is disabled

Screenshot 2024-04-30 at 1 37 25 PM

Actual behavior:

Users are immediately redirected to the OAuth provider, and can't make access requests.

Screen.Recording.2024-04-30.at.1.35.01.PM.mov

Workaround:

Use built-in auth so users can see the login page.
@gabtorre gabtorre added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. customer Important issues reported or desired by a customer. team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 30, 2024
@gabtorre
Copy link
Contributor Author

reported by https://github.com/sourcegraph/accounts/issues/1

@pjlast pjlast self-assigned this May 2, 2024
@pjlast pjlast mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjlast pjlast

Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. customer Important issues reported or desired by a customer. team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if access requests are enabled before redirecting to auth provider sourcegraph/sourcegraph
2 participants
@pjlast @gabtorre