Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Percy tests from storybooks #9565

Closed
felixfbecker opened this issue Apr 3, 2020 · 1 comment · Fixed by #10622
Closed

Add Percy tests from storybooks #9565

felixfbecker opened this issue Apr 3, 2020 · 1 comment · Fixed by #10622

Comments

@felixfbecker
Copy link
Contributor

Percy supports screenshotting storybooks.

  • This way we can expand our stoybook library and get free unit tests for free
  • It adds a layer of testing we are severely undertesting, which is styling
  • It makes it easier for the design team to review changes, as they can review screenshots in Percy
  • One screenshot can replace dozens of assertions, and is way easier to evolve

First came up in https://sourcegraph.slack.com/archives/CMT39K56Z/p1579792526049200

@uwedeportivo
Copy link
Contributor

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.16 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

Web Team :: Current iteration automation moved this from Next to Done May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants