Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL API Search result line numbers #9587

Closed
aisbaa opened this issue Apr 6, 2020 · 1 comment · Fixed by #10660
Closed

GraphQL API Search result line numbers #9587

aisbaa opened this issue Apr 6, 2020 · 1 comment · Fixed by #10660
Assignees
@keegancsmith
Labels
api Sourcegraph GraphQL API customer Important issues reported or desired by a customer. planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue.
Milestone
3.16

Comments

@aisbaa
Copy link

aisbaa commented Apr 6, 2020

  • Sourcegraph version: 3.12.7

Steps to reproduce:

  1. Run this search graphql query

Expected behavior:

Matched result lines are off by 1, seems like API file starts from line 0.

Actual behavior:

Expect file to start from line 1 or mention that it starts from 0 in the docs.

sourcegraph/cmd/frontend/graphqlbackend/schema.graphql

Line 2906 in 94e5aa4

lineNumber: Int!

@eseliger eseliger added team/core-services api Sourcegraph GraphQL API labels Apr 6, 2020
@keegancsmith keegancsmith self-assigned this Apr 16, 2020
@keegancsmith keegancsmith added this to the 3.16 milestone Apr 16, 2020
@keegancsmith keegancsmith added the customer Important issues reported or desired by a customer. label Apr 16, 2020
@tsenart tsenart mentioned this issue Apr 16, 2020
Closed
67 tasks
@tsenart tsenart added the planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue. label Apr 28, 2020
@uwedeportivo
Copy link
Contributor

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.16 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

@keegancsmith keegancsmith mentioned this issue May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keegancsmith keegancsmith

Labels
api Sourcegraph GraphQL API customer Important issues reported or desired by a customer. planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue.
Projects
None yet
Milestone
3.16
Development

Successfully merging a pull request may close this issue.

graphql: document that FileMatch.lineNumber is 0-based sourcegraph/sourcegraph
5 participants
@tsenart @aisbaa @keegancsmith @uwedeportivo @eseliger