Skip to content
This repository has been archived by the owner on May 29, 2018. It is now read-only.

Change SourceImports to ImportFromBinary to follow go/loader updates. #31

Merged
merged 1 commit into from
Feb 25, 2015

Conversation

peterwald
Copy link
Contributor

Reference breaking change in go/loader API
golang/tools@69db398

Fixes #30

@samertm
Copy link
Contributor

samertm commented Feb 25, 2015

Thanks for the pull request. This change looks good to me. We vendor go/loader using godep, and we should update that repository to. If you want to update go/loader, let me know, otherwise I can make that change.

@peterwald
Copy link
Contributor Author

As it turns out, go/loader is not currently vendored. That's what caused the install to fail. Since it's not vendored, go get fetches the fresh version from github on every install.

When I deleted and regenerated all of the dependencies with godep save I got the following error.

godep: Godeps/_workspace/src/golang.org/x/tools/go/loader/testdata/badpkgdecl.go:1:34: expected 'package', found 'EOF'

Looks like there is an intentional error in a .go file in the go/loader package resulting in godep failing to parse it and bailing out before completing the copy. I can manually update the vendored files, but it will likely fail every time it's rerun.

@samertm
Copy link
Contributor

samertm commented Feb 25, 2015

Ah, that's weird. Let me merge this in, then, and you should file that error as a bug report against godep. Thanks again for the contribution!

samertm added a commit that referenced this pull request Feb 25, 2015
Change SourceImports to ImportFromBinary to follow go/loader updates.
@samertm samertm merged commit 72d155b into sourcegraph:master Feb 25, 2015
@peterwald
Copy link
Contributor Author

Opened issue tools/godep#187

beyang pushed a commit that referenced this pull request Mar 5, 2016
Change SourceImports to ImportFromBinary to follow go/loader updates.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

src toolchain install-std broken by change to go/loader
2 participants