This repository has been archived by the owner on May 29, 2018. It is now read-only.
Fetch deps if SRCLIB_FETCH_DEPS env var is set #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the grapher only fetches deps (with go get) if IN_DOCKER_CONTAINER is true: https://github.com/sourcegraph/srclib-go/blob/fd67bff078ee774c13278bd6e709ee4ef7c30136/graph.go#L150 This makes sense if you are running srclib in your development GOPATH; you don't want it checking out different revisions of your GOPATH code. But if you are running srclib-go on a dedicated server without Docker, you do want it to create a temporary GOPATH and fetch deps, just like it would if Docker were enabled. The current behavior results in unresolved refs for any deps that aren't already in the GOPATH, which means a lot of unresolved refs if running on a dedicated, non-Docker server.
|
That explains a lot. LGTM. |
sqs
added a commit
that referenced
this pull request
Oct 2, 2015
Fetch deps if SRCLIB_FETCH_DEPS env var is set
beyang
pushed a commit
that referenced
this pull request
Mar 5, 2016
Fetch deps if SRCLIB_FETCH_DEPS env var is set
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the grapher only fetches deps (with go get) if IN_DOCKER_CONTAINER is true:
srclib-go/graph.go
Line 150 in fd67bff
This makes sense if you are running srclib in your development GOPATH; you don't want it checking out different revisions of your GOPATH code. But if you are running srclib-go on a dedicated server without Docker, you do want it to create a temporary GOPATH and fetch deps, just like it would if Docker were enabled.
The current behavior results in unresolved refs for any deps that aren't already in the GOPATH, which means a lot of unresolved refs if running on a dedicated, non-Docker server.