Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidying up CMake #1 #30

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Tidying up CMake #1 #30

merged 1 commit into from
Feb 4, 2021

Conversation

skrax
Copy link
Contributor

@skrax skrax commented Dec 21, 2020

wrapped dependecies inside cmake targets
removed some global setters (compiler flags)
linking new cmake targets as private (this is good practice in general)

FindFFmpeg.cmake
wrapped components inside cmake targets

@skrax skrax mentioned this pull request Dec 21, 2020
  wrapped dependecies inside cmake targets
  removed some global setters (compiler flags)
  linking new cmake targets as private (this is good practice in general)

FindFFmpeg.cmake
  wrapped components inside cmake targets
@gynt
Copy link
Contributor

gynt commented Dec 21, 2020

Great!

@gynt gynt merged commit 6a29ca7 into sourcehold:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants