Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mouse coordinates #1001

Merged
merged 3 commits into from
Sep 29, 2017
Merged

Fix mouse coordinates #1001

merged 3 commits into from
Sep 29, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 20, 2017

Fixes #1000

@Tyriar Tyriar added this to the 3.0.0 milestone Sep 20, 2017
@Tyriar Tyriar self-assigned this Sep 20, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 69.945% when pulling 79c07d4 on Tyriar:1000_fix_horz_offset into c4da832 on sourcelair:v3.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 69.945% when pulling 79c07d4 on Tyriar:1000_fix_horz_offset into c4da832 on sourcelair:v3.

@Tyriar Tyriar changed the title Fix selection horizontal offset Fix mouse coordinates Sep 28, 2017
@Tyriar
Merge branch 'v3' into 1000_fix_horz_offset
0dafd0a
@Tyriar
Calculate mouse coordinates using correct char dimensions
a817439 
Previously the Mouse class was using raw CSS pixels, we need CSS pixels based
on the amount of space the cells take up on the canvas

See microsoft/vscode#35114
@Tyriar
Copy link
Member Author

Tyriar commented Sep 28, 2017

Added additional changes to this PR that fixes mouse coords when zoom level is not 100%.

@coveralls
Copy link

coveralls commented Sep 28, 2017 •
edited

Coverage Status

Coverage decreased (-0.009%) to 69.937% when pulling a817439 on Tyriar:1000_fix_horz_offset into 313d1e6 on sourcelair:v3.

parisk
parisk approved these changes Sep 29, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Tyriar Tyriar merged commit a9a1316 into xtermjs:v3 Sep 29, 2017
@Tyriar Tyriar deleted the 1000_fix_horz_offset branch September 29, 2017 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tyriar @coveralls @parisk