Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the URI class #710

Open
3 of 7 tasks
jviotti opened this issue May 17, 2024 · 0 comments
Open
3 of 7 tasks

Refactor the URI class #710

jviotti opened this issue May 17, 2024 · 0 comments
Assignees

Comments

@jviotti
Copy link
Member

jviotti commented May 17, 2024

This is a master-issue for collecting requirements for improving the current URI class, reduce its dependency on uriparser, and prepare it for extracting it outside of this project:

auto encode_character(const char character, std::ostream &stream) -> void;
auto encode_string(std::istream &stream, std::ostream &output, const std::set<char> &whitelist) -> void;
auto encode_string(std::istream &stream, std::ostream &output) -> void;
auto decode_character(std::istream &stream, const std::uint64_t column = 0) -> char;
auto decode_string(std::istream &stream, std::ostream &output, const std::uint64_t column = 0) -> void;

On uriparser:

  • Stop storing a UriUriA struct. Parse on the constructor and extract every component as a separate private member on the class, and operate on those from then on. If needed, construct back to UriUriA on the spot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants