Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goheader linter always expects the current year #1020

Closed
shahzadlone opened this issue Jan 3, 2023 · 0 comments · Fixed by #1021
Closed

Goheader linter always expects the current year #1020

shahzadlone opened this issue Jan 3, 2023 · 0 comments · Fixed by #1021
Assignees
Labels
bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Milestone

Comments

@shahzadlone
Copy link
Member

Goheader linter always expects the current year, so make a custom regex to check for any year satisfying 20\d\d.

Problem posted by John on discord:
image

@shahzadlone shahzadlone added bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality labels Jan 3, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5 milestone Jan 3, 2023
@shahzadlone shahzadlone self-assigned this Jan 3, 2023
shahzadlone added a commit that referenced this issue Jan 3, 2023
- Resolves #1020
- Description: Make the go-header linter place holder in the template be any year, instead of current year (default).
jsimnz pushed a commit that referenced this issue Jan 8, 2023
- Resolves #1020
- Description: Make the go-header linter place holder in the template be any year, instead of current year (default).
shahzadlone added a commit that referenced this issue Apr 13, 2023
- Resolves #1020
- Description: Make the go-header linter place holder in the template be any year, instead of current year (default).
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
- Resolves sourcenetwork#1020
- Description: Make the go-header linter place holder in the template be any year, instead of current year (default).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant