Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go version to v1.20 #1687

Closed
shahzadlone opened this issue Jul 22, 2023 · 0 comments · Fixed by #1689
Closed

Bump go version to v1.20 #1687

shahzadlone opened this issue Jul 22, 2023 · 0 comments · Fixed by #1689
Assignees
@shahzadlone
Labels
bump Bumped version for something ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Milestone
DefraDB v0.6

Comments

@shahzadlone
Copy link
Member

Bump go version to v1.20 once v1.21 is released or if we have any vulnerabilities in v1.19 (we do).
@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality bump Bumped version for something labels Jul 22, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.6 milestone Jul 22, 2023
@shahzadlone shahzadlone self-assigned this Jul 22, 2023
This was referenced Jul 22, 2023
Closed
Merged
shahzadlone added a commit that referenced this issue Jul 23, 2023
@shahzadlone
chore: Bump to GoLang v1.20 (#1689)
912824e 
## Relevant issue(s)
- Resolves #522
- Resolves #1687 

## Description
- This is a routine version bump of GoLang, the previous bump was done
in (#818)
- This PR also introduces a new workflow action (not-mandatory to pass
in order to merge) that was showing some vulnerabilities
pre-version-bump, all of the vulnerabilities were resolved once the
golang version was bumped. In future this trigger will be used to bump
golang versions.
- Also updates the golang version for AWS AMI generation.

Note:
- Before the bump we had 13 vulnerabilities:
https://github.com/sourcenetwork/defradb/actions/runs/5629964770/job/15255493129?pr=1688
- After the bump: passing with no vulnerabilities.


## How has this been tested?
- Added action that failed with vulnerabilities.
- Bumped version.
- Vulnerabilities were resolved and action passed.

Specify the platform(s) on which this was tested:
- Arch Linux
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
chore: Bump to GoLang v1.20 (sourcenetwork#1689)
6f2f8dd 
## Relevant issue(s)
- Resolves sourcenetwork#522
- Resolves sourcenetwork#1687 

## Description
- This is a routine version bump of GoLang, the previous bump was done
in (sourcenetwork#818)
- This PR also introduces a new workflow action (not-mandatory to pass
in order to merge) that was showing some vulnerabilities
pre-version-bump, all of the vulnerabilities were resolved once the
golang version was bumped. In future this trigger will be used to bump
golang versions.
- Also updates the golang version for AWS AMI generation.

Note:
- Before the bump we had 13 vulnerabilities:
https://github.com/sourcenetwork/defradb/actions/runs/5629964770/job/15255493129?pr=1688
- After the bump: passing with no vulnerabilities.


## How has this been tested?
- Added action that failed with vulnerabilities.
- Bumped version.
- Vulnerabilities were resolved and action passed.

Specify the platform(s) on which this was tested:
- Arch Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
bump Bumped version for something ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging a pull request may close this issue.

chore: Bump to GoLang v1.20 sourcenetwork/defradb
1 participant
@shahzadlone