Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve log outputs #506

Merged
merged 8 commits into from
Jun 7, 2022
Merged

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Jun 7, 2022

RELEVANT ISSUE(S)

Resolves #505

DESCRIPTION

Simply improving the log outputs regarding their normalization, capitalization, usage of log.ErrorE, etc.

HOW HAS THIS BEEN TESTED?

Local and CI.

CHECKLIST:

  • I have commented the code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the repo-held documentation.
  • I have made sure that the PR title adheres to the conventional commit style (subset of the ones we use can be found under: tools/configs/chglog/config.yml

ENVIRONMENT / OS THIS WAS TESTED ON?

Please specify which of the following was this tested on (remove or add your own):

  • Arch Linux
  • Debian Linux
  • MacOS
  • Windows

@orpheuslummis orpheuslummis added code quality Related to improving code quality action/no-benchmark Skips the action that runs the benchmark. labels Jun 7, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone Jun 7, 2022
@orpheuslummis orpheuslummis self-assigned this Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #506 (41f688f) into develop (45978e0) will not change coverage.
The diff coverage is 52.63%.

❗ Current head 41f688f differs from pull request most recent head 88354c7. Consider uploading reports for the commit 88354c7 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #506   +/-   ##
========================================
  Coverage    65.09%   65.09%           
========================================
  Files           87       87           
  Lines        10242    10242           
========================================
  Hits          6667     6667           
  Misses        2927     2927           
  Partials       648      648           
Impacted Files Coverage Δ
datastore/badger/v3/datastore.go 32.36% <0.00%> (ø)
datastore/blockstore.go 45.65% <0.00%> (ø)
merkle/crdt/merklecrdt.go 21.05% <0.00%> (ø)
query/graphql/planner/type_join.go 69.07% <0.00%> (ø)
merkle/clock/clock.go 63.96% <66.66%> (ø)
db/db.go 53.84% <80.00%> (ø)
db/collection.go 56.17% <100.00%> (ø)
merkle/clock/heads.go 73.45% <100.00%> (ø)

@orpheuslummis orpheuslummis requested a review from a team June 7, 2022 16:03
net/server.go Outdated Show resolved Hide resolved
net/server.go Outdated Show resolved Hide resolved
merkle/clock/clock.go Outdated Show resolved Hide resolved
orpheuslummis and others added 3 commits June 7, 2022 12:52
Co-authored-by: Shahzad Lone <shahzadlone@gmail.com>
Co-authored-by: Shahzad Lone <shahzadlone@gmail.com>
Co-authored-by: Shahzad Lone <shahzadlone@gmail.com>
@shahzadlone
Copy link
Member

shahzadlone commented Jun 7, 2022

PR name can be: chore: Improve log outputs.

Avoid ...ing verbs.

@orpheuslummis orpheuslummis changed the title chore: Improving log outputs chore: Improve log outputs Jun 7, 2022
@orpheuslummis orpheuslummis merged commit 3c91e36 into develop Jun 7, 2022
@orpheuslummis orpheuslummis deleted the chore/orpheus/improve-log-output branch June 7, 2022 18:16
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve log outputs for readability
2 participants