feat: Add explainable renderLimitNode & hardLimitNode attributes. #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
feature
| Description: "Explain Query Request With Only Offset Specified.", | ||
|
|
||
| Query: `query @explain { | ||
| author(offset: 2) { |
There was a problem hiding this comment.
I did not know we could do this lol
There was a problem hiding this comment.
Was also first time finding out haha.
However not sure if that is the desired behavior?
Because if say you have a document in the collection, doing offset >= 1 (i.e. 1) will return no elements.
for example:
query {
author(offset: 1) {
name
}
}
Regardless of the behavior probably discussion for outside the scope of this PR.
There was a problem hiding this comment.
definitely outside of this PR lol, but we seem to be lacking tests for this - will create an issue
shahzadlone
force-pushed
the
lone/feat/explain-attributes-of-limit-nodes
branch
from
7d4a224
to
6741047
Compare
Codecov Report
@@ Coverage Diff @@
## develop #614 +/- ##
===========================================
+ Coverage 56.84% 56.90% +0.05%
===========================================
Files 122 122
Lines 14595 14605 +10
===========================================
+ Hits 8297 8311 +14
+ Misses 5588 5584 -4
Partials 710 710
|
shahzadlone
changed the title
renderLimitNode and hardLimitNode attribute(s).
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…urcenetwork#614) - Resolves: sourcenetwork#561 - Description: Adds the `limit` and `offset` attributes for both `renderLimitNode` and `hardLimitNode` to be included in the returned explain graph response. - Request: ``` query @Explain { author(limit: 3, offset: 1) { numberOfArts: _count(articles: {}) articles(limit: 2) { name } } } ``` - Response: ``` { "data": [ { "explain": { "selectTopNode": { "hardLimitNode": { "limit": 3, "offset": 1, "countNode": { "sources": [ { "fieldName": "articles", "filter": null } ], "selectNode": { "filter": null, "typeIndexJoin": { "joinType": "typeJoinMany", "rootName": "author", "root": { "scanNode": { "collectionID": "3", "collectionName": "author", "filter": null, "spans": [ { "end": "/4", "start": "/3" } ] } }, "subTypeName": "articles", "subType": { "selectTopNode": { "renderLimitNode": { "limit": 2, "offset": 0, "selectNode": { "filter": null, "scanNode": { "collectionID": "1", "collectionName": "article", "filter": null, "spans": [ { "end": "/2", "start": "/1" } ] } } } } } } } } } } } } ] } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #561
Description
Adds the
limitandoffsetattributes for bothrenderLimitNodeandhardLimitNodeto be included in the returned explain graph response.Example:
Request:
Response:
Tasks
How has this been tested?
Integration tests locally and only CI. Specifically
make test.Specify the platform(s) on which this was tested: