Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to GoLang v1.18 #720

Closed
shahzadlone opened this issue Aug 3, 2022 · 0 comments · Fixed by #721
Closed

Bump to GoLang v1.18 #720

shahzadlone opened this issue Aug 3, 2022 · 0 comments · Fixed by #721
Assignees
@shahzadlone
Labels
bump Bumped version for something

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Aug 3, 2022 •
edited

Why:

Process:

  • Bump CI go versions.
  • Bump Linter versions (disable non-compatible ones).
  • Update go.mod.

Other:

  • Even after this PR we should avoid using generics until we have benchmarks working properly.
@shahzadlone shahzadlone self-assigned this Aug 3, 2022
@shahzadlone shahzadlone mentioned this issue Aug 3, 2022
Merged
4 tasks
@shahzadlone shahzadlone added the bump Bumped version for something label Aug 3, 2022
shahzadlone added a commit that referenced this issue Aug 3, 2022
@shahzadlone
chore: Bump to GoLang v1.18 (#721)
906663a 
- Resolves #720 

- Description
  > Bumps Go versions of GitHub Action environment setups.
  > Bumps Docker image Go version.
  > Bumps and resolves Linter issues.
  > Bumps and Updates `go.mod`.

- Limitation
>  A sub-linter was disabled because it lacked support with `v1.18` of Go. Can be easily turned back on if they bump up their support (golangci/golangci-lint#2649).
>  Despite us bumping to 1.18, we internally ban the use of generics until our benchmarks are fixed.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
chore: Bump to GoLang v1.18 (sourcenetwork#721)
64483b0 
- Resolves sourcenetwork#720 

- Description
  > Bumps Go versions of GitHub Action environment setups.
  > Bumps Docker image Go version.
  > Bumps and resolves Linter issues.
  > Bumps and Updates `go.mod`.

- Limitation
>  A sub-linter was disabled because it lacked support with `v1.18` of Go. Can be easily turned back on if they bump up their support (golangci/golangci-lint#2649).
>  Despite us bumping to 1.18, we internally ban the use of generics until our benchmarks are fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
bump Bumped version for something
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Bump to GoLang v1.18 sourcenetwork/defradb
1 participant
@shahzadlone