feat: Implement SourceHub ACP #2657
Draft
+2,348
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
AndrewSisley
force-pushed
the
2366-source-hub
branch
9 times, most recently
from
e957409
to
4005996
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2657 +/- ##
===========================================
- Coverage 79.18% 79.10% -0.08%
===========================================
Files 319 320 +1
Lines 24256 24468 +212
===========================================
+ Hits 19206 19354 +148
- Misses 3665 3708 +43
- Partials 1385 1406 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
force-pushed
the
2366-source-hub
branch
15 times, most recently
from
15f6597
to
d6d6417
Compare
AndrewSisley
force-pushed
the
2366-source-hub
branch
7 times, most recently
from
3fe10a0
to
cf8ac0d
Compare
AndrewSisley
force-pushed
the
2366-source-hub
branch
2 times, most recently
from
0414ffe
to
fd25896
Compare
AndrewSisley
force-pushed
the
2366-source-hub
branch
5 times, most recently
from
4d7d44c
to
b98d1b8
Compare
AndrewSisley
force-pushed
the
2366-source-hub
branch
5 times, most recently
from
e831117
to
c6955cf
Compare
This is needed by a couple of acp packages when running against source-hub
AndrewSisley
force-pushed
the
2366-source-hub
branch
2 times, most recently
from
b5493d9
to
88a072d
Compare
AndrewSisley
force-pushed
the
2366-source-hub
branch
from
88a072d
to
74b4383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2366
Description
Implements SourceHub ACP.
Whilst the time out for a single package has been increased, the CI cost of the new jobs remains about the same as when running with
source-hubacp, the integration test harness will skip all non-acp tests.Warnings
This PR introduces a new dependency to be manually installed by anyone running the tests locally. It is noted in the contributors readme. It can be removed once a SourceHub test harness thing has been built allowing us to stop using the SourceHub CLI in our tests.