feat: Ability to generate a new identity

[shahzadlone]

Relevant issue(s)

Resolves #2554

Description

Now that the core_acp work is merged the identity generation becomes much more simple, with a did instead of source address. This util command can be handy to quickly generate new identity pairs with their did.

Demo

Issue the command:

$ defradb identity new

Output:

{
  "PrivateKey": "8wsOdJZCg06ISJxBqUyrD1ovDF5WgJJrSup2i4avnuU=",
  "PublicKey": "BG6dw3UW3rv+IiTXfL0LXvACw7Qz3DSBy1KmS/eSNrsrRkToBsize7zp+xwFrelPylOPgZguG7ZmirAtTaY89ow=",
  "DID": "did:key:z7r8oqgz72xy7Z7V5WGF21iWc7EY8vCpjZA1nGugoKjGeppeMkqeD7FV5AxEQAnciBz5vk5c2zrTZytofJNM8ZxyBzSpT"
}

How has this been tested?

• cli test
• unit tests

Specify the platform(s) on which this was tested:

• WSL2

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.21%. Comparing base (281aa77) to head (1af8970).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2760      +/-   ##
===========================================
+ Coverage    78.18%   78.21%   +0.03%     
===========================================
  Files          310      313       +3     
  Lines        23071    23111      +40     
===========================================
+ Hits         18038    18076      +38     
- Misses        3663     3664       +1     
- Partials      1370     1371       +1     

Flag	Coverage Δ
all-tests	78.21% <80.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
acp/identity/errors.go	100.00% <ø> (ø)
cli/cli.go	100.00% <100.00%> (ø)
cli/identity.go	100.00% <100.00%> (ø)
cli/identity_new.go	85.71% <85.71%> (ø)
acp/identity/generate.go	60.00% <60.00%> (ø)

... and 12 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281aa77...1af8970. Read the comment docs.

[islamaliev]

LGTM! I just have few minor suggestions.

[islamaliev]

suggestion: would be useful for users to have more detailed documentation on why it's needed and how to use it or something like this.

[shahzadlone]

Happy to take suggestions on what I should add. As for why it's needed (it's not) it's just a key pair + did generation utility command incase users ever want to generate a new identity using defradb rather than another key pair generation tool.

[fredcarle]

LGTM