fix: Return slice of correct length from db.AddSchema

[AndrewSisley]

Relevant issue(s)

Resolves #2764

Description

Return slice of correct length from db.AddSchema, values are appended to this slice later in the function, but the result declaration is done as if they will be set by index.

Bug also affected db.AddView.

I'll create a ticket to allow us to test this properly (the results of AddSchema and AddView` are never asserted by our integration tests atm). Ticket created: #2766

[fredcarle]

LGTM! Thanks for fixing :)

[AndrewSisley]

LGTM! Thanks for fixing :)

Thanks for finding it :)

[shahzadlone]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.23%. Comparing base (f895315) to head (5e78787).

❗ Current head 5e78787 differs from pull request most recent head e3b9fba

Please upload reports for the commit e3b9fba to get more accurate results.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2765      +/-   ##
===========================================
+ Coverage    78.16%   78.23%   +0.07%     
===========================================
  Files          310      310              
  Lines        23071    23071              
===========================================
+ Hits         18032    18049      +17     
+ Misses        3669     3658      -11     
+ Partials      1370     1364       -6     

Flag	Coverage Δ
all-tests	78.23% <100.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
internal/db/collection_define.go	75.26% <100.00%> (ø)

... and 16 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f895315...e3b9fba. Read the comment docs.