Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use cases for titling instead of strings to handle deprecation #457

Merged
merged 1 commit into from
May 18, 2022
Merged

fix: Use cases for titling instead of strings to handle deprecation #457

merged 1 commit into from
May 18, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented May 17, 2022 •
edited

RELEVANT ISSUE(S)

Resolves #454

DESCRIPTION

Handle deprecation of strings.Title

HOW HAS THIS BEEN TESTED?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

CHECKLIST:

  • I have commented the code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the repo-held documentation.
  • I have made sure that the PR title adheres to the conventional commit style (subset of the ones we use can be found under: tools/configs/chglog/config.yml

ENVIRONMENT / OS THIS WAS TESTED ON?

Please specify which of the following was this tested on (remove or add your own):

  • Arch Linux
  • Debian Linux
  • MacOS
  • Windows

@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone May 17, 2022
@orpheuslummis orpheuslummis self-assigned this May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022 •
edited

Codecov Report

Merging #457 (0008fa6) into develop (5e3a3b8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #457      +/-   ##
===========================================
+ Coverage    64.93%   64.94%   +0.01%     
===========================================
  Files           86       86              
  Lines         9998    10001       +3     
===========================================
+ Hits          6492     6495       +3     
  Misses        2867     2867              
  Partials       639      639
Impacted Files Coverage Δ
query/graphql/schema/generate.go 82.20% <100.00%> (+0.06%) ⬆️

@orpheuslummis
Copy link
Contributor Author

Not sure about which language to use yet. For now it is Und

@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 3 Benchmarks were ✅ Better.
  • 110 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4181µs ± 0%177µs ± 0%−2.23%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-414.4µs ± 0%13.6µs ± 0%−5.22%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4195µs ± 0%188µs ± 0%−3.52%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4283ms ± 0%392ms ± 0%+38.49%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-413.6ms ± 0%18.2ms ± 0%+33.84%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4113ms ± 0%158ms ± 0%+39.91%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.21s ± 0%1.67s ± 0%+38.07%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-445.2ms ± 0%51.9ms ± 0%+15.03%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4447ms ± 0%548ms ± 0%+22.64%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.55s ± 0%4.98s ± 0%+9.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4362µs ± 0%426µs ± 0%+17.80%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.88ms ± 0%5.03ms ± 0%+29.65%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-438.7ms ± 0%51.3ms ± 0%+32.50%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4368µs ± 0%510µs ± 0%+38.34%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.92ms ± 0%5.52ms ± 0%+40.75%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4251µs ± 0%584µs ± 0%+132.70%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.83ms ± 0%3.55ms ± 0%+94.30%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-423.4ms ± 0%29.6ms ± 0%+26.51%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4270µs ± 0%342µs ± 0%+26.83%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.83ms ± 0%2.69ms ± 0%+46.75%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.21ms ± 0%1.95ms ± 0%+61.22%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.40ms ± 0%13.72ms ± 0%+45.99%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4431µs ± 0%729µs ± 0%+69.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.25ms ± 0%2.04ms ± 0%+62.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.2ms ± 0%11.3ms ± 0%+10.60%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4408µs ± 0%613µs ± 0%+50.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4435µs ± 0%710µs ± 0%+63.19%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4427µs ± 0%529µs ± 0%+23.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4653µs ± 0%1050µs ± 0%+60.94%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4628µs ± 0%964µs ± 0%+53.63%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4640µs ± 0%795µs ± 0%+24.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4281µs ± 0%414µs ± 0%+47.16%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4285µs ± 0%432µs ± 0%+51.16%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4271µs ± 0%346µs ± 0%+27.70%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4412µs ± 0%664µs ± 0%+61.18%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.46ms ± 0%1.87ms ± 0%+27.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.0ms ± 0%17.0ms ± 0%+42.31%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.9µs ± 0%22.6µs ± 0%+51.32%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.8µs ± 0%21.4µs ± 0%+35.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-417.7µs ± 0%25.9µs ± 0%+46.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-423.3µs ± 0%33.2µs ± 0%+42.46%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4146µs ± 0%182µs ± 0%+24.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4158µs ± 0%189µs ± 0%+19.25%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4155µs ± 0%234µs ± 0%+50.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4172µs ± 0%267µs ± 0%+54.98%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4203µs ± 0%312µs ± 0%+53.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-415.4µs ± 0%23.3µs ± 0%+51.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.4µs ± 0%22.5µs ± 0%+45.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-417.1µs ± 0%21.2µs ± 0%+23.89%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-420.7µs ± 0%27.3µs ± 0%+31.84%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-424.1µs ± 0%32.5µs ± 0%+34.88%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4147µs ± 0%184µs ± 0%+25.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4144µs ± 0%262µs ± 0%+82.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4154µs ± 0%199µs ± 0%+29.33%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4164µs ± 0%233µs ± 0%+41.82%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4206µs ± 0%262µs ± 0%+27.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-451.1µs ± 0%70.9µs ± 0%+38.69%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-452.8µs ± 0%68.1µs ± 0%+28.90%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-452.2µs ± 0%72.0µs ± 0%+38.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-455.2µs ± 0%78.1µs ± 0%+41.42%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-467.2µs ± 0%99.9µs ± 0%+48.67%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4376µs ± 0%562µs ± 0%+49.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4392µs ± 0%552µs ± 0%+40.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4378µs ± 0%572µs ± 0%+51.44%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4461µs ± 0%818µs ± 0%+77.64%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4492µs ± 0%789µs ± 0%+60.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-453.5µs ± 0%61.0µs ± 0%+14.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-462.8µs ± 0%95.4µs ± 0%+51.93%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-455.8µs ± 0%72.8µs ± 0%+30.41%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-471.9µs ± 0%93.2µs ± 0%+29.68%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-480.9µs ± 0%89.4µs ± 0%+10.55%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4396µs ± 0%567µs ± 0%+43.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4412µs ± 0%553µs ± 0%+34.31%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4392µs ± 0%530µs ± 0%+35.42%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4446µs ± 0%642µs ± 0%+43.92%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4517µs ± 0%649µs ± 0%+25.39%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4122µs ± 0%174µs ± 0%+42.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4126µs ± 0%178µs ± 0%+41.02%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4126µs ± 0%168µs ± 0%+33.28%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4135µs ± 0%175µs ± 0%+30.12%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4148µs ± 0%214µs ± 0%+44.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.17ms ± 0%1.64ms ± 0%+39.99%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.27ms ± 0%1.84ms ± 0%+44.36%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.42ms ± 0%1.73ms ± 0%+21.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.44ms ± 0%1.72ms ± 0%+19.43%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.51ms ± 0%2.22ms ± 0%+46.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4153µs ± 0%177µs ± 0%+15.54%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4139µs ± 0%191µs ± 0%+37.59%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4137µs ± 0%170µs ± 0%+23.97%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4153µs ± 0%165µs ± 0%+7.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.25ms ± 0%1.65ms ± 0%+32.10%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.34ms ± 0%1.83ms ± 0%+36.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.27ms ± 0%1.74ms ± 0%+36.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.29ms ± 0%1.76ms ± 0%+36.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.63ms ± 0%2.00ms ± 0%+22.58%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-49.54µs ± 0%13.37µs ± 0%+40.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-49.79µs ± 0%14.93µs ± 0%+52.43%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.7µs ± 0%17.5µs ± 0%+37.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-416.3µs ± 0%20.5µs ± 0%+25.29%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-494.7µs ± 0%135.4µs ± 0%+42.88%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-493.8µs ± 0%158.7µs ± 0%+69.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4109µs ± 0%159µs ± 0%+45.59%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4143µs ± 0%166µs ± 0%+16.43%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4127µs ± 0%152µs ± 0%+19.77%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4126µs ± 0%147µs ± 0%+16.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4133µs ± 0%163µs ± 0%+22.32%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4132µs ± 0%177µs ± 0%+34.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4142µs ± 0%170µs ± 0%+20.28%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.25ms ± 0%1.55ms ± 0%+23.92%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.16ms ± 0%1.75ms ± 0%+50.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.28ms ± 0%1.54ms ± 0%+20.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.29ms ± 0%1.55ms ± 0%+19.77%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.35ms ± 0%1.55ms ± 0%+15.46%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-410.5ms ± 0%14.9ms ± 0%+41.60%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4283ms ± 0%392ms ± 0%+38.49%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-413.6ms ± 0%18.2ms ± 0%+33.84%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4113ms ± 0%158ms ± 0%+39.91%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.21s ± 0%1.67s ± 0%+38.07%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-445.2ms ± 0%51.9ms ± 0%+15.03%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4447ms ± 0%548ms ± 0%+22.64%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.55s ± 0%4.98s ± 0%+9.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4362µs ± 0%426µs ± 0%+17.80%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.88ms ± 0%5.03ms ± 0%+29.65%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-438.7ms ± 0%51.3ms ± 0%+32.50%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4368µs ± 0%510µs ± 0%+38.34%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.92ms ± 0%5.52ms ± 0%+40.75%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4251µs ± 0%584µs ± 0%+132.70%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.83ms ± 0%3.55ms ± 0%+94.30%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-423.4ms ± 0%29.6ms ± 0%+26.51%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4270µs ± 0%342µs ± 0%+26.83%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.83ms ± 0%2.69ms ± 0%+46.75%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4383µs ± 0%506µs ± 0%+32.33%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.21ms ± 0%1.95ms ± 0%+61.22%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.40ms ± 0%13.72ms ± 0%+45.99%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4431µs ± 0%729µs ± 0%+69.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.25ms ± 0%2.04ms ± 0%+62.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.2ms ± 0%11.3ms ± 0%+10.60%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4408µs ± 0%613µs ± 0%+50.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4435µs ± 0%710µs ± 0%+63.19%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4427µs ± 0%529µs ± 0%+23.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4653µs ± 0%1050µs ± 0%+60.94%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4628µs ± 0%964µs ± 0%+53.63%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4640µs ± 0%795µs ± 0%+24.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4281µs ± 0%414µs ± 0%+47.16%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4285µs ± 0%432µs ± 0%+51.16%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4271µs ± 0%346µs ± 0%+27.70%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4412µs ± 0%664µs ± 0%+61.18%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.46ms ± 0%1.87ms ± 0%+27.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.0ms ± 0%17.0ms ± 0%+42.31%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-414.3µs ± 0%27.5µs ± 0%+92.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.9µs ± 0%22.6µs ± 0%+51.32%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.8µs ± 0%21.4µs ± 0%+35.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-417.7µs ± 0%25.9µs ± 0%+46.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-423.3µs ± 0%33.2µs ± 0%+42.46%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4146µs ± 0%182µs ± 0%+24.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4158µs ± 0%189µs ± 0%+19.25%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4155µs ± 0%234µs ± 0%+50.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4172µs ± 0%267µs ± 0%+54.98%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4203µs ± 0%312µs ± 0%+53.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-415.4µs ± 0%23.3µs ± 0%+51.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.4µs ± 0%22.5µs ± 0%+45.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-417.1µs ± 0%21.2µs ± 0%+23.89%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-420.7µs ± 0%27.3µs ± 0%+31.84%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-424.1µs ± 0%32.5µs ± 0%+34.88%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4147µs ± 0%184µs ± 0%+25.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4144µs ± 0%262µs ± 0%+82.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4154µs ± 0%199µs ± 0%+29.33%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4164µs ± 0%233µs ± 0%+41.82%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4206µs ± 0%262µs ± 0%+27.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-451.1µs ± 0%70.9µs ± 0%+38.69%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-452.8µs ± 0%68.1µs ± 0%+28.90%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-452.2µs ± 0%72.0µs ± 0%+38.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-455.2µs ± 0%78.1µs ± 0%+41.42%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-467.2µs ± 0%99.9µs ± 0%+48.67%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4376µs ± 0%562µs ± 0%+49.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4392µs ± 0%552µs ± 0%+40.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4378µs ± 0%572µs ± 0%+51.44%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4461µs ± 0%818µs ± 0%+77.64%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4492µs ± 0%789µs ± 0%+60.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-453.5µs ± 0%61.0µs ± 0%+14.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-462.8µs ± 0%95.4µs ± 0%+51.93%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-455.8µs ± 0%72.8µs ± 0%+30.41%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-471.9µs ± 0%93.2µs ± 0%+29.68%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-480.9µs ± 0%89.4µs ± 0%+10.55%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4396µs ± 0%567µs ± 0%+43.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4412µs ± 0%553µs ± 0%+34.31%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4392µs ± 0%530µs ± 0%+35.42%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4446µs ± 0%642µs ± 0%+43.92%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4517µs ± 0%649µs ± 0%+25.39%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4122µs ± 0%174µs ± 0%+42.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4126µs ± 0%178µs ± 0%+41.02%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4126µs ± 0%168µs ± 0%+33.28%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4135µs ± 0%175µs ± 0%+30.12%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4148µs ± 0%214µs ± 0%+44.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.17ms ± 0%1.64ms ± 0%+39.99%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.27ms ± 0%1.84ms ± 0%+44.36%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.42ms ± 0%1.73ms ± 0%+21.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.44ms ± 0%1.72ms ± 0%+19.43%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.51ms ± 0%2.22ms ± 0%+46.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4153µs ± 0%177µs ± 0%+15.54%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4139µs ± 0%191µs ± 0%+37.59%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4137µs ± 0%170µs ± 0%+23.97%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4153µs ± 0%165µs ± 0%+7.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4181µs ± 0%177µs ± 0%−2.23%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.25ms ± 0%1.65ms ± 0%+32.10%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.34ms ± 0%1.83ms ± 0%+36.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.27ms ± 0%1.74ms ± 0%+36.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.29ms ± 0%1.76ms ± 0%+36.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.63ms ± 0%2.00ms ± 0%+22.58%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-49.54µs ± 0%13.37µs ± 0%+40.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-49.79µs ± 0%14.93µs ± 0%+52.43%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-414.4µs ± 0%13.6µs ± 0%−5.22%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.7µs ± 0%17.5µs ± 0%+37.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-416.3µs ± 0%20.5µs ± 0%+25.29%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-494.7µs ± 0%135.4µs ± 0%+42.88%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-493.8µs ± 0%158.7µs ± 0%+69.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4109µs ± 0%159µs ± 0%+45.59%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4143µs ± 0%166µs ± 0%+16.43%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4195µs ± 0%188µs ± 0%−3.52%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4127µs ± 0%152µs ± 0%+19.77%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4126µs ± 0%147µs ± 0%+16.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4133µs ± 0%163µs ± 0%+22.32%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4132µs ± 0%177µs ± 0%+34.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4142µs ± 0%170µs ± 0%+20.28%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.25ms ± 0%1.55ms ± 0%+23.92%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.16ms ± 0%1.75ms ± 0%+50.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.28ms ± 0%1.54ms ± 0%+20.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.29ms ± 0%1.55ms ± 0%+19.77%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.35ms ± 0%1.55ms ± 0%+15.46%(p=1.000 n=1+1)
 

@orpheuslummis orpheuslummis requested review from jsimnz, AndrewSisley, shahzadlone and fredcarle and removed request for jsimnz and AndrewSisley May 17, 2022 17:21
@jsimnz
Copy link
Member

jsimnz commented May 17, 2022

@sourcenetwork/database-team

@orpheuslummis orpheuslummis merged commit 7d52547 into develop May 18, 2022
@orpheuslummis orpheuslummis deleted the fix/orpheus/handling-deprecation-cases-for-title branch May 18, 2022 20:20
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
fix: Use x/cases for titling instead of strings to handle deprecation (…
a08564e 
…sourcenetwork#457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@jsimnz jsimnz Awaiting requested review from jsimnz

@shahzadlone shahzadlone Awaiting requested review from shahzadlone

Assignees

@orpheuslummis orpheuslummis

Labels
None yet
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

strings.Title has been deprecated since Go 1.18
5 participants
@orpheuslummis @source-devs @jsimnz @fredcarle @AndrewSisley