feat: Add null support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code is mostly copy-pasted from the PR graphql-go#536 - main difference is that I haven't copied over a couple of new tests, and that I permitted null within arrays (unanswered question in original PR, and I see no reason for it too).
AndrewSisley
requested review from
orpheuslummis,
jsimnz,
fredcarle and
shahzadlone
1 task
shahzadlone
reviewed
Sep 12, 2022
| @@ -1188,7 +1188,7 @@ func TestVariables_ListsAndNullability_DoesNotAllowListOfNonNullsToContainNull(t | |||
| { | |||
| Message: `Variable "$input" got invalid value ` + | |||
| `["A",null,"B"].` + | |||
| "\nIn element #1: Expected \"String!\", found null.", | |||
| "\nIn element #2: Expected \"String!\", found null.", | |||
There was a problem hiding this comment.
question: do you know why was this saying element #1 was null before?
fredcarle
reviewed
Sep 13, 2022
Comment on lines
+44
to
+48
| if tmp == nil { | ||
| return nullValue{} // Null value | ||
| } else { | ||
| return tmp | ||
| } |
There was a problem hiding this comment.
suggestion: No else needed here since if ends with a return.
There was a problem hiding this comment.
Seems to be the norm in this repo, will leave as is unless we decide to take full ownership of the project
There was a problem hiding this comment.
If it's copy pasted code I'll agree but if it's our code I would change it to the idiomatic form.
fredcarle
pushed a commit
that referenced
this pull request
Apr 25, 2023
Code is mostly copy-pasted from the PR graphql-go#536 - main difference is that I haven't copied over a couple of new tests, and that I permitted null within arrays (unanswered question in original PR, and I see no reason for it too).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves sourcenetwork/defradb#410
Code is mostly copy-pasted from the PR graphql-go#536 by https://github.com/mpenick - main difference is that I haven't copied over a couple of new tests, and that I permitted null within arrays (unanswered question in original PR, and I see no reason for it too). I have changed that code as little as possible otherwise. Builds and tests pass.
Follows the GQL spec as far as I can see (Nulls got added here: graphql/graphql-spec#83)
I have incorporated this feature into a Defra branch and it seems to be working https://github.com/sourcenetwork/defradb/compare/sisley/feat/I410-filter-by-nil?expand=1 (got more tests to write though, will finish those before merging this)