New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add value- and char-array support to co_reduce functions. #332
Conversation
vehre
commented
Feb 8, 2017
Add support for recude-functions with value parameters. Add support for char-arrays as arguments to reduce-functions. Rename co_reduce_1 to internal_co_reduce to get a better naming. Create mpi-datatype to transport the char-array length. Improved cleanup of co_broadcast. Fixed co_reduce_string testcase. Fixes #172.
@zbeekman: On your comments on the previous pull request:
You use my limited time for fixing bugs and adding features or for fixing style. Your choice! :-) |
Codecov Report@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 45.73% 46.22% +0.48%
==========================================
Files 3 3
Lines 1019 1045 +26
Branches 193 201 +8
==========================================
+ Hits 466 483 +17
- Misses 476 483 +7
- Partials 77 79 +2 Continue to review full report at Codecov.
|
OK, you could probably have included it with the patch, but that's fine
Obviously you don't use Emacs ;-p
That's perfectly acceptable... your approach is fine
well I'm happy to clean up after you, at least until I get a better handle on the gfortran internals etc.... :-) |