Use size_t for character lengths with GFortran >= 8.x #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GFortran 8.x uses size_t for character lengths instead of int. This patch applies the same changes to OpenCoarrays. Also, the STOP and ERROR STOP routines now take a plain int for the numeric exit code. This fixes sourceryinstitute#497.
|
|
|
The corresponding GFortran changes are in r257894. |
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
- Coverage 49.36% 49.35% -0.02%
==========================================
Files 3 3
Lines 3087 3088 +1
==========================================
Hits 1524 1524
- Misses 1563 1564 +1 |
|
LGTM |
|
@jabl Many thanks for porting these changes over to OpenCoarrays! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GFortran 8.x uses size_t for character lengths instead of int. This
patch applies the same changes to OpenCoarrays. Also, the STOP and
ERROR STOP routines now take a plain int for the numeric exit code.
This fixes
#497.
This pull request (PR) is a:
I certify that
- Increasing test coverage for all feature-addition PRs
- Increasing test coverage for all bug-fix PRs for which there
does not already exist a related test that failed before the PR
- At least maintaining test coverage for all other PRs
- Ensuring that all tests pass when run locally
- Naming PR to indicate work in progress (WIP) and to attach the PR
to the appropriate bug report or feature request [issue]
- White space (no trailing white space or white space errors may
be introduced)
- Commenting code where it is non-obvious and non-trivial
- Logically atomic, self consistent and coherent commits
- Commit message content
- Waiting 24 hours before self-approving the PR to give another
OpenCoarrays developer a chance to review my proposed code