Fix #632 coarray image-selector image index values for teams #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
==========================================
+ Coverage 53.02% 53.98% +0.96%
==========================================
Files 3 3
Lines 2863 2923 +60
==========================================
+ Hits 1518 1578 +60
Misses 1345 1345 |
|
@nathanweeks Are these PRs ready to merge? |
|
Looking at #632, it appears that this should not be merged. |
Translate image-selector image indices to be w.r.t. the current team. Untested for sendget_by_ref due to possible issue described in sourceryinstitute#632.
nathanweeks
force-pushed
the
issue-632-coarrays-teams
branch
from
b5efab8
to
31af933
Compare
nathanweeks
changed the title
|
Note that additional modifications would be needed when OpenCoarrays adds support for the optional TEAM= and TEAM_NUMBER= specifiers in image selectors. |
|
Is someone available to review this PR? It seems important for the use of teams in OpenCoarrays. |
|
Sorry didn’t realize it was ready. I’ll take a look later today. Thanks for
the ping!
…On Sun, Apr 21, 2019 at 5:28 AM Nathan Weeks ***@***.***> wrote:
Is someone available to review this PR? It seems important for the use of
teams in OpenCoarrays.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#633 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACEIPGH5IGN3L3F3FF6WKDPRQXVJANCNFSM4GWKILFQ>
.
|
zbeekman
added
ready to merge
|
@nathanweeks I pushed to your branch because the PR was out of date WRT master and a merge conflict needed resolving. As soon as CI is green I'm going to merge this. I've tested extensively locally with both MPICH/GCC and OpenMPI/clang. 💯 Fantastic work here! PR looks great as do the additional tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Update OpenCoarrays get(), send(), and sendget() to look up the MPI rank of the executing image in the MPI group(s) of the MPI window(s) of the coarray(s) when determining if the image index(es) for the coarray(s) references the executing image.
Rationale for changes
Fix #632
Additional info and certifications
This pull request (PR) is a:
I certify that
- Increasing test coverage for all feature-addition PRs
- Increasing test coverage for all bug-fix PRs for which there
does not already exist a related test that failed before the PR
- At least maintaining test coverage for all other PRs
- Ensuring that all tests pass when run locally
- Naming PR to indicate work in progress (WIP) and to attach the PR
to the appropriate bug report or feature request [issue]
- White space (no trailing white space or white space errors may
be introduced)
- Commenting code where it is non-obvious and non-trivial
- Logically atomic, self consistent and coherent commits
- Commit message content
- Waiting 24 hours before self-approving the PR to give another
OpenCoarrays developer a chance to review my proposed code