Fix #629 #641
Merged
Fix #629 #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
zbeekman
reviewed
Mar 18, 2019
.VERSION
Outdated
| @@ -1,6 +1,6 @@ | |||
| $Format:%d%n%n$ | |||
| # Fall back version, probably last release: | |||
| 2.3.1 | |||
| 2.5.0 | |||
There was a problem hiding this comment.
This is a duplicate change with your other PR. If you were to have based this branch from master I can do an octopus merge later and merge both at once.
There was a problem hiding this comment.
Oops. I just merged the other one and deleted the branch. I assume there's no problem with merging this one too. I would expect git is smart enough to recognize the duplicate commit and only add in what's new. I hope it's ok if I go for it.
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
=======================================
Coverage 55.77% 55.77%
=======================================
Files 4 4
Lines 3159 3159
=======================================
Hits 1762 1762
Misses 1397 1397 |
|
I clicked "Update branch" and will merge this once the tests pass again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Deleted '!' in environment variable evaluations in
report_results.shinstallation script.Rationale for changes
The previous fix didn't work for me on Lubuntu.
Additional info and certifications
This pull request (PR) is a:
I certify that
- Increasing test coverage for all feature-addition PRs
- Increasing test coverage for all bug-fix PRs for which there
does not already exist a related test that failed before the PR
- At least maintaining test coverage for all other PRs
- Ensuring that all tests pass when run locally
- Naming PR to indicate work in progress (WIP) and to attach the PR
to the appropriate bug report or feature request issue
- White space (no trailing white space or white space errors may
be introduced)
- Commenting code where it is non-obvious and non-trivial
- Logically atomic, self consistent and coherent commits
- Commit message content
- Waiting 24 hours before self-approving the PR to give another
OpenCoarrays developer a chance to review my proposed code