Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerhub build hook #650

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Fix dockerhub build hook #650

merged 1 commit into from
Apr 11, 2019

Conversation

zbeekman
Copy link
Collaborator

  • Extra/erroneous tags were being inserted when run on dockerhub infra
coverage on master
Codecov branch

Summary of changes

Dockerhub build hook (script)

Rationale for changes

So that pushes to master will build the docker image and that can be used to launch a jupyter-CAF-kernel binder notebook based on the master branch.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

 - Extra/erroneous tags were being inserted when run on dockerhub infra
@ghost ghost assigned zbeekman Apr 10, 2019
@ghost ghost added the needs-review label Apr 10, 2019
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #650 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files           3        3           
  Lines        2863     2863           
=======================================
  Hits         1518     1518           
  Misses       1345     1345

@zbeekman zbeekman merged commit b6628f6 into master Apr 11, 2019
@zbeekman zbeekman deleted the fix-docker-hook branch April 11, 2019 00:37
@ghost ghost removed the needs-review label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant