Update GCC default-minimum version to 10.1.0 & fix compiler version check #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. This ensures co_broadcast handles derived type arguments. 2. This also updates the gcc download to use git as it appears GCC no longer provides tarballs on the ftp server and because many users can't use ftp for security reasons. 3. This can still be overrided for users who want to build OpenCoarrays with an older version by passing the -f, -c, and -C arguments (or their longer equivalents).
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 54.53% 54.53%
=======================================
Files 3 3
Lines 2923 2923
=======================================
Hits 1594 1594
Misses 1329 1329 |
The function target_compile_options in combination with generator expressions does not handle strings with space separated compiler flags and inserts quotes. Also MPI_<lang>_COMPILE_FLAGS is deprecated since cmake 3.10 and should be replaced by MPI_<lang>_COMPILE_OPRIONS and MPI_<lang>_COMPILE_DEFINITIONS. Those variables are already lists of compiler flags and thus well suited to solve the bug. This fixes the build error described in issue #676 when using MPICH, which is the same error as described in issue #704. Signed-off-by: Elias Lettl <elias.lettl@physik.uni-augsburg.de>
When building with `BUILD_SHARED_LIBS=ON` it will otherwise be build as a shared library but in the function `caf_compile_executable` it is hardcoded as a static library. Thus leading to the build error described in issue #676.
The `STATIC` keyword for the targets `opencoarrays_mod` and `opencoarrays_test_utilities` could now probably be removed.
Fix static lib opencoarrays_test_utilities not found (issue 676)
Fix MPI compile flags to not include quotation marks (issue-704)
1. The GCC version can still be overriden for users who want to build OpenCoarrays with an older version by passing the -f, -c, and -C arguments or their longer equivalents. 2. Updaing the GCC version ensures co_broadcast handles derived-type arguments. 3. This commit also updates the gcc download to use git to fix the problem of ftp being present and therefore chosen as the default even though ftp access is blocked by a user's network (for security reasons).
…coarrays into default-to-gcc-10
rouson
changed the title
rouson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Set
install.shto default to building GCC 10.1.0 if an earlier version is detected and no other version is specified. This can still be over-rided for users who want to build OpenCoarrays with an older version by passing the-f,-c, and-Carguments (or their longer equivalents).Rationale for changes
gitbecause GCC has moved fromsvntogitandbecause many users cannot access the GCC
ftpserver for security reasons.prerequisites/acceptable_compiler.f90, which failed when the acceptable compiler version matched the actual version.Additional info and certifications
This pull request (PR) is a:
co_broadcastby default)I certify that
OpenCoarrays developer a chance to review my proposed code
be introduced)
Code coverage data