Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 739 fix seg fault #741

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conversation

vehre
Copy link
Collaborator

@vehre vehre commented Oct 11, 2021

coverage on master
Codecov branch

Summary of changes

Fix a crash when indexing into static array.

Rationale for changes

Prevent a segfault.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

- Do not manipulation the memptr but add to data_offset.
Copy link
Member

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson
Copy link
Member

rouson commented Oct 19, 2021

@everythingfunctional could you take a look at what's happening with the "pullapprove Failed to load extends URL (HTTP 404)" message above?

@everythingfunctional
Copy link
Collaborator

I've not seen the WIP or pullapprove checks before, and I don't see anything in the code in the repository that would indicate enabling them. Is there some GitHub setting/new feature that got turned on?

@rouson
Copy link
Member

rouson commented Oct 19, 2021

@everythingfunctional thanks for checking. I found an email indicating that this is third-party app. I don't recall enabling, but I think I have now disabled it. I also replied to the email to ask how to remove it from this PR. I also tried merging into main at the command line, but my subsequent push was rejected.

@rouson rouson merged commit 342421c into issue-733-impl-random-init Oct 20, 2021
@rouson rouson deleted the issue-739-fix-seg-fault branch October 20, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants