Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile warnings LOGICAL -> INT #744

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

vehre
Copy link
Collaborator

@vehre vehre commented Jan 10, 2022

Fix compile warnings about Logical to Integer conversions using the
transfer()-function.

coverage on master
Codecov branch

Summary of changes

Fix compile warnings LOGICAL -> INT

Rationale for changes

Get rid of occurring compile warnings.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

Fix compile warnings about Logical to Integer conversions using the
transfer()-function.
@vehre
Copy link
Collaborator Author

vehre commented Jan 10, 2022

Er, is license check functional?

@rouson rouson merged commit 34b0db9 into main Jan 20, 2022
@rouson rouson deleted the issue-743-fix-compile-warnings branch January 20, 2022 20:57
@rouson
Copy link
Member

rouson commented Jan 20, 2022

@vehre I tried removing the CLA license GitHub webhook, but it didn't remove the CLA check on PRs so I disabled protections on the main branch, merged at the command line and pushed to main. I also removed the pullapprove webhook, but that pull approve still appears on PRs too. I'm at a loss as to how to remove the license check and pullapprove check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants