-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support #755
Windows support #755
Commits on Mar 23, 2022
-
Build: Fix paths passed as flag args w/ spaces
Add some quotes to paths passed as compiler flag arguments in CMake
Configuration menu - View commit details
-
Copy full SHA for 4e2ab32 - Browse repository at this point
Copy the full SHA 4e2ab32View commit details -
Build: Remove genexp in CMake try_compile() flag
This fixes a broken build on windows, and seems like it should not have been working when using Makefile generators on any platform, i.e., macOS & other *nix
Configuration menu - View commit details
-
Copy full SHA for cf4f9ab - Browse repository at this point
Copy the full SHA cf4f9abView commit details
Commits on Mar 26, 2022
-
CMake will build OpenCoarrays on windows w/ GCC & IMPI
The library now builds with Intel MPI (from Intel OneAPI) and GCC + GFortran. There are still some path handling quirks and string quoting things that need to be resolved to get the caf and cafrun wrapper scripts working reliably. A test program can be built and run by tweaking/fixing the commands attempted by the caf script. The program executes correctly and then encounters an error during MPI finalize/when shutting down.
Configuration menu - View commit details
-
Copy full SHA for 344ac30 - Browse repository at this point
Copy the full SHA 344ac30View commit details
Commits on Apr 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9cac967 - Browse repository at this point
Copy the full SHA 9cac967View commit details -
Make cafrun.in more robust & runable on windows
No special changes needed beyond robustness improvements
Configuration menu - View commit details
-
Copy full SHA for 0abce5a - Browse repository at this point
Copy the full SHA 0abce5aView commit details -
Improve windows support: find pthreads & use in caf
Use CMakes FindThreads feature/module to find pthreads since they are used in the mpi opencoarrays library. As a result the caf wrapper script should also link in/build with pthreads
Configuration menu - View commit details
-
Copy full SHA for a65958c - Browse repository at this point
Copy the full SHA a65958cView commit details
Commits on May 4, 2022
-
Merge branch 'main' of github.com:sourceryinstitute/OpenCoarrays into…
… windows-support
Configuration menu - View commit details
-
Copy full SHA for f873d11 - Browse repository at this point
Copy the full SHA f873d11View commit details -
The intrinsic FindMPI module seems like it has some bugs or documentation bugs. I got this working, but it is a bit of black magic as to how/why it works. It simplifies the code, however, and should offload some maintanence upstream, so it's worth doing.
Configuration menu - View commit details
-
Copy full SHA for 95f9355 - Browse repository at this point
Copy the full SHA 95f9355View commit details
Commits on May 5, 2022
-
Bump min. cmake ver. & modernize FindMPI
Some usage of deprecated variables provided in older version of FindMPI were removed, updating them to the new, correct variables. The cmake_minimum_required_version was also bumped along with CMake policies.
Configuration menu - View commit details
-
Copy full SHA for 6e81ea4 - Browse repository at this point
Copy the full SHA 6e81ea4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ed3c4a - Browse repository at this point
Copy the full SHA 2ed3c4aView commit details -
Add caf & cafrun batchfile wrapper scripts on windows
These scripts get configured to call the bash version found during CMake configuration time. Using this version/installation of bash, the batch files call the corresponding bash caf & cafrun scripts and pass all arguments through. This *should* allow things like fpm to work with the caf wrapper scripts, *I beleive* (untested) CAVEAT: WSL's bash will dump you into your WSL home directory and there's no obvious work around. If you put Git-Bash's bash.exe (in the bin subdirectory) first on your path you *should* be in business (I think). There may be weird edge cases.
Configuration menu - View commit details
-
Copy full SHA for 6b2c49a - Browse repository at this point
Copy the full SHA 6b2c49aView commit details -
Make CMake, project build & test more robust on Windows
If you have Git-Bash's bash.exe in the front of your path, you can now do everything from within the Intel OneAPI CMD.exe shell. If you experience issues you should launch git-bash from the OneAPI CMD.exe shell and it will inherit your environment variables and be more robust. If CMake finds WSL, you're probably hosed.
Configuration menu - View commit details
-
Copy full SHA for a426966 - Browse repository at this point
Copy the full SHA a426966View commit details -
More FindMPI and try_compile() CMake modernization
A bunch of the variable manipulation should be abstracted as a function.
Configuration menu - View commit details
-
Copy full SHA for abd921c - Browse repository at this point
Copy the full SHA abd921cView commit details -
Make sure we have perl before trying to run style tests, especially on
windows. Also invoke perl directly so style/linting on windows works.
Configuration menu - View commit details
-
Copy full SHA for 084e1ae - Browse repository at this point
Copy the full SHA 084e1aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ab99ab - Browse repository at this point
Copy the full SHA 9ab99abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02ec792 - Browse repository at this point
Copy the full SHA 02ec792View commit details
Commits on May 7, 2022
-
Fix typos & style improvements from code review
Thanks to @rouson and @everythingfunctional for the review and great suggestions! Co-authored-by: Damian Rouson <rouson@lbl.gov> Co-authored-by: Brad Richardson <everythingfunctional@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for eef9548 - Browse repository at this point
Copy the full SHA eef9548View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8bc08e - Browse repository at this point
Copy the full SHA e8bc08eView commit details