Strips down <i> tag

[Ahuahuachi]

Don't know if this is an issue, but if you activate the "strip down comments" option, it also strips down the < i > tag, which I use it for the Font Awesome icons.

[jnaskali]

This is especially an issue with fontawesome, which uses empty < i > tags for icon placement.

I thought adding the tag to empty_tags and inline_tags would do the trick, but this has no effect. As a workaround, I add a html comment inside the tags. It gets removed, but tidy still lets the tag itself stay: <i class="fa fa-github" aria-hidden="true"><!--icon--></i>

[sourcesoldier]

@Ahuahuachi Thanks for the report. I did some research and it seems like this is know problem in the outdated versions of tidy. Apparently the most OS dists like Debian, etc. are using totally outdated versions.

I guess updating (meaning self-compiling to a more recent fork) could help in this case. Then there should be an option {"drop-empty-elements":"no"} that tackles the problem.

I believe the only way of making this work for a broad majority would be a dirty workaround with implementing a new fake TAG, introducing this in the new-empty-elementsoption and then replacing it in the cleaned output again. Kinda hackish but might work ...

[OleVik]

Can confirm that this is an issue, spent some hours debugging and the lack of an option to not drop empty elements can cause major issues in functionality that is common to modern HTML5-patterns. Lot of frameworks depend on <i>-elements for navigation - both visual and with ARIA - and the current version of the plugin breaks this.

[sourcesoldier]

@OleVik that's true, sadly.

I've managed to compile my own version of php-tidy on my Debian Wheezy. That's a lot more stable and actually respects the settings, that my module is setting (e.g. new-empy-elements). Unfortunately the version that get's shipped with most package maintainers (e.g. apt-get, aptitute) is almost 3 years old and buggy.

I guess a solution could be to bound this module to a specific mayor version of php-tidy and only enabled it with prior warning.

[jonsparks]

Has there been any progress made on this? I'm having the same problem on one of my sites.

[gidlov]

@jonsparks
I do not know if this is the solution, but it works for me (PHP 7.1.12-1 &
libTidy 5.4.0). I have added an option to drop empty elements that fix this in my fork. According to Tidy documentation, this option is available since version 5.0.0. By default, this is done.

[sourcesoldier]

@jonsparks I've merged the changes by @gidlov, can you check if that solves your issue?

[Dadido3]

I had the same problem here, and the new option fixes the problem.

But it would be nice if it could be released, as the grav plugin manager is still downloading the version from 2016.

Thanks.