Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove max_hash from Minhash.__init__ #1303

Closed
ctb opened this issue Feb 5, 2021 · 2 comments
Closed

Remove max_hash from Minhash.__init__ #1303

ctb opened this issue Feb 5, 2021 · 2 comments

Comments

@ctb
Copy link
Contributor

ctb commented Feb 5, 2021

per #1301 (comment), we're close to removing max_hash entirely.
@ctb ctb added the 4.0 issues to address for a 4.0 release label Feb 5, 2021
@ctb
Copy link
Contributor Author

ctb commented Feb 5, 2021

I'm setting this for 4.0, but might punt to 5.0.

@ctb ctb mentioned this issue Feb 6, 2021
Open
@ctb ctb removed the 4.0 issues to address for a 4.0 release label Mar 3, 2021
@ctb ctb mentioned this issue May 10, 2021
Open
@ctb
Copy link
Contributor Author

ctb commented Aug 3, 2022 •
edited
Loading

it's been a useful optimization to have max_hash around (e.g. see SqliteIndex), and it's now _max_hash so explicitly private. Closing for now; MinHash will hopefully undergo a lot of changes soon and we'll just redesign as we go.

@ctb ctb closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb