Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions and concerns for 4.0.0rc1 #1338

Closed
ctb opened this issue Feb 17, 2021 · 8 comments
Closed

Questions and concerns for 4.0.0rc1 #1338

ctb opened this issue Feb 17, 2021 · 8 comments

Comments

@ctb
Copy link
Contributor

ctb commented Feb 17, 2021

please add comments below if you have questions or concerns about sourmash v4.0 release candidate 1

See also comments on twitter thread

@klamens
Copy link

klamens commented Feb 18, 2021

'accept file list in sourmash sig cat (#1236)' - Could we also have it for the sketch function (input fasta files)?

@ctb
Copy link
Contributor Author

ctb commented Feb 18, 2021 via email

@klamens
Copy link

klamens commented Feb 18, 2021

On Thu, Feb 18, 2021 at 02:29:28AM -0800, klamens wrote: 'accept file list in sourmash sig cat (#1236)' - Could we also have it for the sketch function (input fasta files)?
well THAT's a brilliant idea! laugh yes :)

On Windows there is a max number of characters for the command line - VERY annoying when we have a lot of input files. A file list would help a lot! Tnx!!

@ctb
Copy link
Contributor Author

ctb commented Feb 18, 2021

👍 - also happy to drop you some snakemake Snakefiles that do this for you, which is what we use - enables parallelism! - but this is a great feature idea :)

@ctb
Copy link
Contributor Author

ctb commented Feb 20, 2021

per Mick - https://twitter.com/BioMickWatson/status/1362753564381175814 - how about updated database etc?

@ctb
Copy link
Contributor Author

ctb commented Mar 4, 2021

@klamens please see #1362 for --from-file.

@ctb
Copy link
Contributor Author

ctb commented Mar 12, 2021

@klamens the new feature (--from-file on sourmash sketch) will be released in the next version of sourmash, along with other recent changes. We don't have a firm date for that release but it will be sourmash v4.1.0, probably by end of April.

If you want to try it out before then and need our help, please let us know!

@ctb
Copy link
Contributor Author

ctb commented May 21, 2021

done!

@ctb ctb closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants