Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up sourmash_args.load_dbs_and_sigs(...) with scaled/num selectors #1376

Closed
ctb opened this issue Mar 8, 2021 · 0 comments · Fixed by #1406
Closed

clean up sourmash_args.load_dbs_and_sigs(...) with scaled/num selectors #1376

ctb opened this issue Mar 8, 2021 · 0 comments · Fixed by #1406

Comments

@ctb
Copy link
Contributor

ctb commented Mar 8, 2021

As I'm going through sourmash_args.load_dbs_and_sigs(...) for #1373 and #1374, I'm seeing a good opportunity for some refactoring and simplification around providing scaled/num selectors per #1072

A few thoughts -

  • if we added scaled/num selectors we could eliminate the filter_compatible_signatures check on lists of signatures;
  • I think that would also remove the check_lca_db_is_compatible and check_tree_is_compatible checks;
  • this would collapse the entire function down to something ...much smaller, although we might not be able to remove the conditionals on database/siglist type unless we wanted to change the notify output to just talk about total signatures loaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant